From nobody Fri Aug 8 22:35:32 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bzJl91Qjtz64Gp6; Fri, 08 Aug 2025 22:35:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bzJl90kPYz40NS; Fri, 08 Aug 2025 22:35:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754692533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vgWj6y787rdj8W76eJn+LXS1jPzAaVy2qFncl4DEDh8=; b=o/Q2IVDqHZZdj0bonq/m2dV1MbmSepsqjPufp7Oah1EDiPXw++T9FcahgTxmmSh6manzXO pRz/2+2BaJutxihEAWcBjxW7fDQetJupRqDsh24t/EQnVM2wXrj6NfEdsq7BpTZp78PVX6 4Zou5y3QnlC4oACxBFTrVrRX1O9FgzYGQxcoGep21yCDSdEQdf+bCpy6nhKYx9MmylKv1y 0kGol1f3CBsVpqTEzbW8AYbPlvgguLRqQNZc5gZBIv09cUSOS+dKbmUFAGlzt6I7Y5e55Q UEiArkq6ohsOnaryvQbRhsnXoDusv/mxIHVne6c9GqOMowvUHndjSJU7rz2jVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754692533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vgWj6y787rdj8W76eJn+LXS1jPzAaVy2qFncl4DEDh8=; b=WPiU24A4offMSntFu4fe6GnlOnE3CgGAnV10kJfjKYMNdgrzbiWOcnQ0h5E6WcIEdnA838 DP91XoOfCQ9RDXQJU+wv/aK/es5jeMOspRLJA0r0LL82QVF5Fx8HBkMXpnIMxR/8GZ1U/H n+J9WSoUjYb5HEL5bSQwHFQztGrwOUyk7tTTz2BkEMeyVMjt8+INvZkBDsd2k4qEtZ9HtE pjVVsmQW4XiX+Xr3ZZ5QCcOEiFdeEsEGxvVL/1vgWgsTY2xT6PH58SBIc+EX1uFlBuRXAD s9gdyzeVz2xogalrTI923ljuka0R3W3kd0OwGkAzKp1eHGNPCREL3Dc3Pa29kw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754692533; a=rsa-sha256; cv=none; b=N2NvMUx/IBsXNVBFNZKQlvW9W1kv8U0vU27g2JAZmPJ4VHjFHBOK2PMaoUrbrk9YDg1M2Q 2eAhEY2uL6t15SezR/KSiK4CmlYvRgbDqVqErOwxHf6PcBs+8+IYVOXtjfFIwyd2F/G5YY UXz9dzIG8M8UF/eBte3YgfrPXNTk+87CwEhAx/3F4+FvPIoSvCO0VqIhuPwhFHlYJHIac5 aL2Ba6ZIOJeEWcfNWA75KP6Tlfhv+rAT5fUmmNJ/1FOHoslv818fPeLUaqEDr6els/Turw CB11jh6ALBPRvCNphPrw+HDiyeJYcUMDUTK/xVsxKGgKtLmCNMY1/sfJAnlDWg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bzJl875fyzvpf; Fri, 08 Aug 2025 22:35:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 578MZWYu043932; Fri, 8 Aug 2025 22:35:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 578MZWSo043929; Fri, 8 Aug 2025 22:35:32 GMT (envelope-from git) Date: Fri, 8 Aug 2025 22:35:32 GMT Message-Id: <202508082235.578MZWSo043929@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 33dd42e63298 - main - inetd: don't assume that initgroups(3) will set the egid List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 33dd42e632982ba324789f47041d03ceb65f6560 Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=33dd42e632982ba324789f47041d03ceb65f6560 commit 33dd42e632982ba324789f47041d03ceb65f6560 Author: Kyle Evans AuthorDate: 2025-08-08 22:34:56 +0000 Commit: Kyle Evans CommitDate: 2025-08-08 22:35:04 +0000 inetd: don't assume that initgroups(3) will set the egid inetd, in the ident provider, seems to be the only initgroups(3) caller in base that assumes it will set the egid. Everyone else uses it as it's typically used on other platforms: to initialize supplementary groups. --- usr.sbin/inetd/builtins.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/usr.sbin/inetd/builtins.c b/usr.sbin/inetd/builtins.c index 9609faf0b104..21ce44c77033 100644 --- a/usr.sbin/inetd/builtins.c +++ b/usr.sbin/inetd/builtins.c @@ -606,6 +606,8 @@ ident_stream(int s, struct servtab *sep) */ if (initgroups(pw->pw_name, pw->pw_gid) == -1) iderror(lport, fport, s, ID_UNKNOWN); + if (setegid(pw->pw_gid) == -1) + iderror(lport, fport, s, ID_UNKNOWN); if (seteuid(pw->pw_uid) == -1) iderror(lport, fport, s, ID_UNKNOWN); /*