From owner-freebsd-arm@FreeBSD.ORG Sat Dec 21 18:38:53 2013 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C05BFE20 for ; Sat, 21 Dec 2013 18:38:53 +0000 (UTC) Received: from mail-qc0-x230.google.com (mail-qc0-x230.google.com [IPv6:2607:f8b0:400d:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7F4E31956 for ; Sat, 21 Dec 2013 18:38:53 +0000 (UTC) Received: by mail-qc0-f176.google.com with SMTP id i8so3485669qcq.7 for ; Sat, 21 Dec 2013 10:38:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=EQ5yiBSv2B2cWxB+vreW3aN00vqDUMZIXC9FBwYreZ4=; b=RTOxiJgVczkJcoAZdlAq37L9E4tD48q72GGu8W0xQtK4OBf/Kp6h8L53XgJQWuW07t Y2mkVN2Q7xoVe1ZqioSeeiSfDw7NIHuor32qt3lCWEhyTBmho4gjkji29wRChRTZapy4 JuRgTZaMRye/9MgY3Ildg4bFlltGNJ2OXx2T3yMsAYni/rmnwm35uUjzrshPmq+1YhML BN5rQ5DDHpVQlptJdtVQtGex00LA1p0nQ2AlkX+JllUxPi1f1+Z47XiYVgjKBaZXxQUz I+YCM+lDTo6wy6Q9gJLq231L/ReYQy7ULOR81y8QalmX6oZgiiqQlOCsfDXPdu+7TIaX +3QA== MIME-Version: 1.0 X-Received: by 10.224.16.204 with SMTP id p12mr27090187qaa.26.1387651132663; Sat, 21 Dec 2013 10:38:52 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.224.53.200 with HTTP; Sat, 21 Dec 2013 10:38:52 -0800 (PST) In-Reply-To: References: Date: Sat, 21 Dec 2013 10:38:52 -0800 X-Google-Sender-Auth: OTdNjkkFiNOpfUFHS6vPOitaR3g Message-ID: Subject: Re: 10.0-RC1: net/mpd5 crashes in NgMkSockNode due to stack alignment on ARM EABI From: Adrian Chadd To: Guy Yur Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-arm@freebsd.org" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 18:38:53 -0000 Hi! Would you mind filing a PR with what you've put in the email? That way it is less likely to get lost. Thanks! -a On 21 December 2013 09:24, Guy Yur wrote: > Hi, > > I am running 10.0-RC1 on the BeagleBone Black and the net/mpd5 port is > crashing in libnetgraph NgMkSockNode due to stack alignment. > > 10.0-RC1 World and kernel were compiled in a VirtualBox VM running > 9.2-RELEASE-p2 i386. > clang and ARM_EABI used as the default make options. > > Added prints in NgMkSockNode show rbuf is aligned on 2-byte and not > 4-byte which is needed to access ni->id (a uint32_t). > > ni = 0xbfffe87a > rbuf = 0xbfffe842 > sizeof(resp->header) = 56 > > > (gdb) bt > #0 0x201529a0 in NgMkSockNode (name=, csp=0xbfffe95c, > dsp=0xbfffe958) at /usr/src/lib/libnetgraph/sock.c:134 > #1 0x00037b9c in MppcTestCap () at ccp_mppc.c:754 > #2 0x0007c1f4 in main (ac=4, av=0xbfffeb90) at main.c:248 > #3 0x0000d1b0 in __start (argc=4, argv=0xbfffeb90, env=0xbfffeba4, > ps_strings=, obj=, > cleanup=) at /usr/src/lib/csu/arm/crt1.c:115 > #4 0x203e9dc0 in _thr_ast (curthread=0x200fd000) > at /usr/src/lib/libthr/thread/thr_sig.c:265 > > > Putting rbuf in a union with struct ng_mesg sorted the alignment to > 4-byte and mpd5 didn't crash. > I attached the changes I used to test mpd5 doesn't crash with correct alignment. > > > Regards, > Guy > > _______________________________________________ > freebsd-arm@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org"