From owner-svn-ports-all@freebsd.org  Sat Jul 14 14:25:23 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 233A4102CD7C;
 Sat, 14 Jul 2018 14:25:23 +0000 (UTC)
 (envelope-from seanc@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CA33A7B937;
 Sat, 14 Jul 2018 14:25:22 +0000 (UTC)
 (envelope-from seanc@FreeBSD.org)
Received: from localhost (unknown [104.153.224.167])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate) (Authenticated sender: seanc)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 94A5E19007;
 Sat, 14 Jul 2018 14:25:16 +0000 (UTC)
 (envelope-from seanc@FreeBSD.org)
Date: Sat, 14 Jul 2018 07:24:10 -0700
From: Sean Chittenden <seanc@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r473756 - head/security/teleport
Message-ID: <20180714142410.mdn7rwphwveeojml@FreeBSD.org>
References: <201807021659.w62GxDgI031531@repo.freebsd.org>
 <20180702192120.bmrv74c4atutx26b@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="aijyojrnkjwo542o"
Content-Disposition: inline
In-Reply-To: <20180702192120.bmrv74c4atutx26b@atuin.in.mat.cc>
User-Agent: NeoMutt/20180512
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Jul 2018 14:25:23 -0000


--aijyojrnkjwo542o
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> > Modified: head/security/teleport/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- head/security/teleport/Makefile	Mon Jul  2 16:45:53 2018	(r473755)
> > +++ head/security/teleport/Makefile	Mon Jul  2 16:59:13 2018	(r473756)
> > @@ -45,9 +45,9 @@ post-extract:
> >  post-patch:
> >  	@${REINPLACE_CMD} -e 's|^GITREF=3D.*|GITREF=3D${GH_TAG_COMMIT}|' \
> >  		${WRKDIR}/${GO_TELEPORT_SRC_DIR}/version.mk
> > -	@${FIND} ${WRKDIR} -type f \
> > -		-exec ${SED} -i '' -e 's|\/var\/lib|/var/db|g' {} \; \
> > -		-exec ${SED} -i '' -e 's|\/usr\/bin\/hostname|/bin/hostname|g' {} \;
> > +	@${FIND} ${WRKDIR} -type f -exec ${SED} -i '' \
> > +		-e 's|\/var\/lib|/var/db|g' \
> > +		-e 's|\/usr\/bin\/hostname|/bin/hostname|g' {} \;
>=20
> Now, you are only running one sed for each file in WRKDIR instead of two.
> Let's cut that down to only one sed call for all the files, please replace
> "\;" with "+".

[ Sorry, I've been traveling for the last week and unable to dig into this =
or test ]

Huh, I didn't know find(1) had an `-exec +` mode, and yes, that's the right=
 way
to update the ports.  TIL.  Thanks!  -sc

--=20
Sean Chittenden

--aijyojrnkjwo542o
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEE74y44SUGZ4YNR0/x11Nmqtx5Ry0FAltKB4lfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVG
OENCOEUxMjUwNjY3ODYwRDQ3NEZGMUQ3NTM2NkFBREM3OTQ3MkQACgkQ11Nmqtx5
Ry1Cvgf+Md7144IxfQ/CPbOjA7af76CbS4rdR2HiLw/ml4Prw4xmvLUVa6O2k/ir
T+ryWjBUkXT9XTtj5XNAnyPIqEBPmWGWy+LS/X64Vy7AUHkysao+IznjYCT2p0/R
CiglaSXaEq76zInHRph/xzN/WgV9WsdShY+Zzmbz7KcZxseo/9LE73RqxBtd30AM
L7XAAC0yrl94h/c+/PcZHRxe7/71oAmAYM2H6VEH1IH+WcXuMO+k8q4gGQ+wmRQw
oyWXPTw+4ShKESDKc98ZegTDdqjJSP1F7/4LGZSdcXzVLS9c8SBvHDtGi4G7cIQ4
ByjTTpJ7/TTa1/s+avkm5uQMI8Artw==
=qDfV
-----END PGP SIGNATURE-----

--aijyojrnkjwo542o--