From owner-cvs-all  Tue Mar 11  2:50:24 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 86D2137B401; Tue, 11 Mar 2003 02:50:22 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EDB8143F85; Tue, 11 Mar 2003 02:50:19 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id VAA29830;
	Tue, 11 Mar 2003 21:50:16 +1100
Date: Tue, 11 Mar 2003 21:50:15 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "Jacques A. Vidrine" <nectar@FreeBSD.org>
Cc: "David E. O'Brien" <obrien@FreeBSD.org>,
	"" <src-committers@FreeBSD.org>, "" <cvs-src@FreeBSD.org>,
	"" <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/secure/lib/libcrypto Makefile
In-Reply-To: <20030310200645.GB5060@madman.celabo.org>
Message-ID: <20030311213028.B24561@gamplex.bde.org>
References: <200303101943.h2AJhuX2037826@repoman.freebsd.org>
 <20030310200645.GB5060@madman.celabo.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 10 Mar 2003, Jacques A. Vidrine wrote:

> On Mon, Mar 10, 2003 at 11:43:56AM -0800, David E. O'Brien wrote:
> > obrien      2003/03/10 11:43:56 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     secure/lib/libcrypto Makefile
> >   Log:
> >   Don't error out the build if removing a "stale" symlink fails.
>
> Oops, sorry.  How does `rm -f' "error out"?  The `-f' should have
> "hidden" any non-zero exit status.  I guess it does not in all cases?

rm -f only ignores ENOENT errors.  There are open PRs about "rm -rf"
being broken on read-only file systems, but only "rm -f" is used so
this can't be the problem.  (rm normally sees ENOENT from lstat; for
the -r case it blunders on and tries to unlink the file, and most file
systems have the dubious behaviour of returning EROFS instead of ENOENT
for attempts to unlink nonexistent files, so rm -rf of a nonexistent
file (in an existent directory) sees EROFS and correctly barfs on it.)

So there seem to be 2 bugs removing the symlinks now:
- '-' before rm to hide bugs in rm.
- "echo" hard-coded to break "make -s".

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message