From owner-svn-src-head@freebsd.org  Tue Jul 28 14:43:28 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B9C679ADD51;
 Tue, 28 Jul 2015 14:43:28 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4674FFB9;
 Tue, 28 Jul 2015 14:43:27 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t6SEhPbX086033
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 28 Jul 2015 17:43:25 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t6SEhPBp086032;
 Tue, 28 Jul 2015 17:43:25 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 28 Jul 2015 17:43:25 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Renato Botelho <garga@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r285945 - head/sys/netpfil/pf
Message-ID: <20150728144325.GZ72729@FreeBSD.org>
References: <201507281031.t6SAVZnu046387@repo.freebsd.org>
 <20150728112051.GT72729@FreeBSD.org>
 <DA51CE87-C20B-46FB-8684-106CDF9B558F@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DA51CE87-C20B-46FB-8684-106CDF9B558F@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2015 14:43:28 -0000

  Renato,

On Tue, Jul 28, 2015 at 10:18:57AM -0300, Renato Botelho wrote:
R> Thanks for pointing this out. Do you approve the following patch?
R> 
R> Index: sys/netpfil/pf/pf.c
R> ===================================================================
R> --- sys/netpfil/pf/pf.c	(revision 285945)
R> +++ sys/netpfil/pf/pf.c	(working copy)
R> @@ -5895,8 +5895,7 @@
R>  	    !((s && s->state_flags & PFSTATE_ALLOWOPTS) || r->allow_opts)) {
R>  		action = PF_DROP;
R>  		REASON_SET(&reason, PFRES_IPOPTIONS);
R> -		if (r->log)
R> -			log = 1;
R> +		log = r->log;
R>  		DPFPRINTF(PF_DEBUG_MISC,
R>  		    ("pf: dropping packet with ip options\n"));
R>  	}
R> @@ -6330,8 +6329,7 @@
R>  	    !((s && s->state_flags & PFSTATE_ALLOWOPTS) || r->allow_opts)) {
R>  		action = PF_DROP;
R>  		REASON_SET(&reason, PFRES_IPOPTIONS);
R> -		if (r->log)
R> -			log = 1;
R> +		log = r->log;
R>  		DPFPRINTF(PF_DEBUG_MISC,
R>  		    ("pf: dropping packet with dangerous v6 headers\n"));
R>  	}

Yes, this looks better. Thanks.

-- 
Totus tuus, Glebius.