Date: Mon, 15 Aug 2005 14:28:56 +0200 (CEST) From: Rudolf Cejka <cejkar@fit.vutbr.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/84948: sysutils/smartmontools: Patches for 3ware twa support Message-ID: <200508151228.j7FCSuT6093021@kazi.fit.vutbr.cz> Resent-Message-ID: <200508151230.j7FCUJD9022764@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 84948 >Category: ports >Synopsis: sysutils/smartmontools: Patches for 3ware twa support >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Aug 15 12:30:19 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Rudolf Cejka >Release: FreeBSD 5.3-STABLE i386 >Organization: FIT, Brno University of Technology, Czech Republic >Environment: >Description: I have created patches for port sysutils/smartmontools for 3ware twa support. However they are somewhat longer, so I have uploaded them to ftp://ftp.FreeBSD.cz/pub/FreeBSD-local/smartmontools-5.33-twa/: patch-config.h.in - just in the case if twa include files are installed patch-configure.in - just in the case if twa include files are installed (both untested and they are not needed for port) patch-os_freebsd.h - copy outs from twa include files patch-os_freebsd.c.2 - it is not sufficient to test just ioctl() return value in FreeBSD, because when SMART is disabled, ioctl() returns 0 and only request.error indicates, that something went wrong (and I have removed one perror(), because it produced not very fine output, when smartctl -i /dev/ad0 has been called on drive with disabled SMART: Unknown error 0) (this patch is for better smartctl functionality and is useful in all cases, even without twa support) patch-os_freebsd.c.3 - main patch for twa support with one redundant line "cmd->tu_command.ata.sector_count = 1;" removed. I have mailed about twa support to maintainer (martines@rochester.rr.com) at Sun, 7 Aug 2005, however still without response, so I decided to send them as PR too, so it is not forgotten. >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508151228.j7FCSuT6093021>