From owner-cvs-src@FreeBSD.ORG Wed Nov 3 16:52:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F42316A4CE; Wed, 3 Nov 2004 16:52:08 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id C4F4B43D49; Wed, 3 Nov 2004 16:52:07 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id iA3GncSo040805; Wed, 3 Nov 2004 09:49:38 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 03 Nov 2004 09:49:45 -0700 (MST) Message-Id: <20041103.094945.22504907.imp@bsdimp.com> To: scottl@FreeBSD.ORG From: "M. Warner Losh" In-Reply-To: <41890956.2030705@freebsd.org> References: <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> <41890956.2030705@freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: rizzo@icir.org cc: src-committers@FreeBSD.ORG cc: phk@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 16:52:08 -0000 In message: <41890956.2030705@freebsd.org> Scott Long writes: : Luigi Rizzo wrote: : > On Wed, Nov 03, 2004 at 09:23:01AM -0700, Scott Long wrote: : > ... : > : >>I think that in general we can start eyeing a lot of similar verbosity : >>in all of our drivers, both at boot and at runtime. For example most : >>nic drivers print out their MAC and all of their possible negotiation : >>rates on attach. This same info can be obtained from ifconfig. Why : >>clutter the boot with it? : > : > : > because sometimes you might need to enable some MAC-based filter : > before you have a chance to access the box. e.g. to set dhcp/bootp : > anbd the like. : > : > A bit of verbosity is useful, you can always switch to splash screens : > if you don't like them. : > : > I think the link-up/link-down thing is different because it : > happens not just at boot but also whenever the link status : > changes (e.g. when a spanning tree on a switch detects a : > reconfiguration), and this is annoying on the console. : > : > cheers : > luigi : > : : I'm not saying that these things should be removed, just places under : bootverbose. Situations like what you are saying are rare and/or : one-time occurances. And if you look at drivers like if_ath(no offense : meant towards Sam): : : ath0: mem 0xf4010000-0xf401ffff irq 11 at device 0.0 on : cardbus1 : ath0: mac 5.6 phy 4.1 5ghz radio 1.7 2ghz radio 2.3 : ath0: Ethernet address: 00:0c:41:15:5f:94 : ath0: 11a rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps : ath0: 11b rates: 1Mbps 2Mbps 5.5Mbps 11Mbps : ath0: 11g rates: 1Mbps 2Mbps 5.5Mbps 11Mbps 6Mbps 9Mbps 12Mbps 18Mbps : 24Mbps 36Mbps 48Mbps 54Mbps : ath0: turbo rates: 6Mbps 9Mbps 12Mbps 18Mbps 24Mbps 36Mbps 48Mbps 54Mbps : : The last 4 lines could easily go under bootverbose. I'd even wager that : the second line can be hidden also; it provides little useful : information for a normal boot. Agreed. The second line should likely be exported as a series of sysctls under dev.ath.0.mac_version, dev.ath.0.phy_version, etc if they are important. Warner