From owner-svn-ports-all@freebsd.org  Sat Feb 23 10:08:33 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CA4B150F91C;
 Sat, 23 Feb 2019 10:08:33 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3FB97842A4;
 Sat, 23 Feb 2019 10:08:33 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 0EF7717607; Sat, 23 Feb 2019 10:08:33 +0000 (UTC)
Date: Sat, 23 Feb 2019 10:08:33 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Ryan Steinmetz <zi@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-svnadmin@freebsd.org
Subject: Re: svn commit: r493633 - svnadmin/hooks/scripts
Message-ID: <20190223100832.GA23828@FreeBSD.org>
References: <201902230159.x1N1x3vr074164@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201902230159.x1N1x3vr074164@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 3FB97842A4
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.92 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.92)[-0.919,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Feb 2019 10:08:33 -0000

On Sat, Feb 23, 2019 at 01:59:03AM +0000, Ryan Steinmetz wrote:
> New Revision: 493633
> URL: https://svnweb.freebsd.org/changeset/ports/493633
> 
> Log:
>   - Make error message useful
>   
>   PR:		226864, 231327
>   Approved by:	portmgr (implicit, noop)
> 
> Modified:
>   svnadmin/hooks/scripts/verify.py
> 
> +        self.do_fail('Do not replace a file, this can lose history. Try: svn cp;svn commit, then add your changes and commit.  Path: "%s"\n' % path)

There's no need to commit after "svn cp".  Also, the whitespace bugs here
are preposterous.  You should've requested someone to review these changes
prior to committing them.

./danfe