Date: Mon, 5 Dec 2005 00:03:36 +0300 From: Yar Tikhiy <yar@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/periodic/daily 470.status-named Message-ID: <20051204210336.GA18653@comp.chem.msu.su> In-Reply-To: <200511222224.jAMMOSMJ087945@repoman.freebsd.org> References: <200511222224.jAMMOSMJ087945@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 22, 2005 at 10:24:28PM +0000, Doug Barton wrote: > dougb 2005-11-22 22:24:28 UTC > > FreeBSD src repository > > Modified files: > etc/periodic/daily 470.status-named > Log: > Update the test for failed zone transfers to reflect BIND 9.3.1 semantics > Simplify the shell scripting a bit, and remove a useless grep | sed > > The problem was pointed out by the PR, and I used part of the solution > suggested there, but the semantics changed again for 9.2.x -> 9.3.x. > > PR: conf/74228 > Submitted by: Jeremy Chadwick <freebsd@jdc.parodius.com> > > Revision Changes Path > 1.7 +8 -10 src/etc/periodic/daily/470.status-named Excuse me for this late comment, but using `fgrep -E' looks odd to me because `fgrep' and `grep -E' are orthogonal and mutually exclusive. I mean the following part of the change: - fgrep '^'"$start"'.*named\[[[:digit:]]\+\]: denied [AI]XFR from \[.*\]\.[[:digit:]]\+ for' | \ - sed -e 's/.*: denied [AI]XFR from \[\(.*\)\]\.[[:digit:]]* for "\(.*\)".*$/\2 from \1/' + fgrep -E ".*named\[[[:digit:]]+\]: transfer of .*failed .*: REFUSED" | + sed -e "s/.*transfer of \'\(.*\)\/IN\' from \(.*\)#[0-9]*: .*/\1 from \2/" | In the older version it was just broken as it passed a regexp to plain fgrep. Now it should work, but still looks strange. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051204210336.GA18653>