From owner-svn-src-head@freebsd.org Mon Apr 9 08:36:00 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9AFACF8F522; Mon, 9 Apr 2018 08:36:00 +0000 (UTC) (envelope-from royger@gmail.com) Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D18B7A2A8; Mon, 9 Apr 2018 08:36:00 +0000 (UTC) (envelope-from royger@gmail.com) Received: by mail-wm0-x236.google.com with SMTP id r191so17027532wmg.4; Mon, 09 Apr 2018 01:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mIeL8MStg/IyrwzX3MbeAknLDcJgxaEKI5uGo6XNYZI=; b=lxQhu3mIU5/WImTpwMfgVR+WSlsCtHRHBYUWfPMjQmyAFMwDkzopfLBcm3spojn/G4 zZj+tLrQ4fDejZAImes6/lblgxni7DydQXqr7tawjniwJIma1ew+XRtUddP2oD1TxEFc ASxkoU3A6qRoJc6ua+m1UWw5ZEFjmc+Qysh6waHmnPc0XyBhMhINR7q3UuQ8vZJ8TsKh Z/zasuSW3yG0Km2Karj1Xk93qMPcLvoPc3ZR74ccCDZW9FGfW8NxuePQVLaVQ4mPrcsb qnyRyS68crgQXo4dAS0iV/lBSBoq19IEHXNsXN5q+ww4fUWqlg6FrMUimGrXVmbL65EU tmWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mIeL8MStg/IyrwzX3MbeAknLDcJgxaEKI5uGo6XNYZI=; b=mrYZ/ucn5cFrkNEewjlIKoEp372Sjkqs2qS4EDOk4dMX4dNqiShjeNihOVr+dVskCh lXkcDbu7oqdM/UnkyN6msX7ewrhvvsTk20zUGKpa5xLdJfpEPwp7+az1Kph8v4FHd3/Q ah0ZVyCxS2dKcgivCLon1CjSfVbcA5fb0dMTz1ifWa+2Rz39qzfo26tIPuZ9c/zf+VIv jOIm/81GgGnO8MrSYNGLhGG6Rf5HyLk+bg8EVYFh2GSOpuIPfYCaHEf67Hg/xyVKn99/ NiXDQNS/9ZFj3xxwpLBVwM2GCFMAzTQSje2IV56klbudPSUHxalXtm1wz+52yOUZ/YV7 71Rw== X-Gm-Message-State: ALQs6tC4UcIrQaREWDLOJfFa+fB3cMibA+s49HAlXFTJP2g/r3q4azbS VtqOletT9uLdDIVWXN9Gs3CKgg== X-Google-Smtp-Source: AIpwx4+YaIS90HJpJKh5irpIy7af40sdbgvqideGlUwdATxKWFZy1AwWqLsuh6A+ssjVZMuvP/TEDw== X-Received: by 10.80.179.92 with SMTP id r28mr9892284edd.145.1523262958354; Mon, 09 Apr 2018 01:35:58 -0700 (PDT) Received: from localhost (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id q19sm74948edd.39.2018.04.09.01.35.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Apr 2018 01:35:57 -0700 (PDT) Sender: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Date: Mon, 9 Apr 2018 09:35:54 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86 Message-ID: <20180409083554.k34hfijxiztwdne6@MacBook-Pro-de-Roger.local> References: <201804061120.w36BK6s6074635@repo.freebsd.org> <201804061617.w36GH9sw003442@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201804061617.w36GH9sw003442@pdx.rh.CN85.dnsmgr.net> User-Agent: NeoMutt/20180323 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 08:36:00 -0000 On Fri, Apr 06, 2018 at 09:17:09AM -0700, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: royger > > Date: Fri Apr 6 11:20:06 2018 > > New Revision: 332092 > > URL: https://svnweb.freebsd.org/changeset/base/332092 > > > > Log: > > remove GiB/MiB macros from param.h > > > > And instead define them in the files where they are used. > > It would of been better to "revert" your prior change and > make a seperate new commit. It is rarely desireable to combine > a revert of a change with anything. A plain revert of r332072 would have left the tree in a broken state, because r332073 depends on those macros. IMO it's better to have a buildable tree at all times in order for it to be bisectable. Roger.