Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 Dec 2006 13:19:49 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        "Stephane E. Potvin" <sepotvin@videotron.ca>
Cc:        freebsd-current@freebsd.org
Subject:   Re: EHCI problem on -current, and unknown devs
Message-ID:  <457490F5.8050007@FreeBSD.org>
In-Reply-To: <45742EB4.8060405@videotron.ca>
References:  <4564996D.50808@FreeBSD.org> <200611301443.31419.jhb@freebsd.org> <456FA276.6050706@videotron.ca> <200612011225.02780.jhb@freebsd.org> <45742EB4.8060405@videotron.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
Stephane E. Potvin wrote:

> I had to modify the patch a little again to make it compile. With this
> slight modification (changing rm->link to rm->list), the patch seems to
> be working fine and I got back my ehci controller.
> 
> Index: subr_rman.c
> ===================================================================
> RCS file: /home/FreeBSD/ncvs/src/sys/kern/subr_rman.c,v
> retrieving revision 1.53
> diff -u -r1.53 subr_rman.c
> --- subr_rman.c 11 Sep 2006 19:31:52 -0000      1.53
> +++ subr_rman.c 1 Dec 2006 15:25:59 -0000
> @@ -61,6 +61,7 @@
>  #include <sys/param.h>
>  #include <sys/systm.h>
>  #include <sys/kernel.h>
> +#include <sys/limits.h>
>  #include <sys/lock.h>
>  #include <sys/malloc.h>
>  #include <sys/mutex.h>
> @@ -169,10 +170,12 @@
>         mtx_lock(rm->rm_mtx);
> 
>         /* Skip entries before us. */
> -       for (s = TAILQ_FIRST(&rm->rm_list);
> -            s && s->r_end + 1 < r->r_start;
> -            s = TAILQ_NEXT(s, r_link))
> -               ;
> +       TAILQ_FOREACH(s, &rm->rm_list, r_link) {
> +               if (s->r_end == ULONG_MAX)
> +                       break;
> +               if (s->r_end + 1 >= r->r_start)
> +                       break;
> +       }
> 
>         /* If we ran off the end of the list, insert at the tail. */
>         if (s == NULL) {
> 
> Thanks a lot!

With Stephane's change this works for me as well.

Doug

-- 

    This .signature sanitized for your protection




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?457490F5.8050007>