From owner-freebsd-acpi@FreeBSD.ORG Wed Jun 8 20:39:39 2005 Return-Path: X-Original-To: freebsd-acpi@freebsd.org Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DEFDE16A41C; Wed, 8 Jun 2005 20:39:39 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from mh1.centtech.com (moat3.centtech.com [207.200.51.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7418E43D4C; Wed, 8 Jun 2005 20:39:38 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from [10.177.171.220] (neutrino.centtech.com [10.177.171.220]) by mh1.centtech.com (8.13.1/8.13.1) with ESMTP id j58KdbbJ028093; Wed, 8 Jun 2005 15:39:37 -0500 (CDT) (envelope-from anderson@centtech.com) Message-ID: <42A75772.2050400@centtech.com> Date: Wed, 08 Jun 2005 15:39:14 -0500 From: Eric Anderson User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050603 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <200506032012.j53KCC5k077879@repoman.freebsd.org> <42A6DA72.2070105@centtech.com> <42A73FEE.4090202@root.org> In-Reply-To: <42A73FEE.4090202@root.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.82/921/Wed Jun 8 03:51:44 2005 on mh1.centtech.com X-Virus-Status: Clean Cc: freebsd-acpi@freebsd.org, Warner Losh Subject: Re: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2005 20:39:40 -0000 Nate Lawson wrote: > Eric Anderson wrote: > >> Warner Losh wrote: >> >>> imp 2005-06-03 20:12:12 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/acpica acpi.c Log: >>> In newbus land, ivars can only be accessed for direct child, or when >>> the driver has unholy private knowledge of its great-*cgrandchildren. >>> The ACPI allocation routine lacked such knowledge when it tried to do >>> a default allocation for all descendants, rather than just its >>> immeidate children, so would access grandchild's ivar in an unsafe >>> way. This could lead to a panic when devices were present which had >>> no addresses setup by the BIOS, but which were later allocated in a >>> lazy manner via pci_alloc_map. As such, only do the default >>> allocation adjustments for immediate children. The manner that >>> acpi_sysres_find accesses the resource list, used later in >>> acpi_alloc_resource, is safe and proper so no additional test is >>> needed there. >>> This fixes a panic when probing an disabled ata controller on some >>> newer intel blades. >>> Reported by: dwhite >>> Revision Changes Path >>> 1.214 +1 -1 src/sys/dev/acpica/acpi.c >> >> >> >> Warner - I owe you a beer! I believe this commit got my Dell D610 >> laptop (and maybe the D600's?) to go into S3 mode, which prior to this >> commit it would power off the machine instead of going into S3. > > > Great. It should be MFCd also. Awesome!! Now does anyone have any hints on how I can start looking at why it powers off instead of resumes? Screen is blank the whole time so it's hard to tell whats happening. Eric -- ------------------------------------------------------------------------ Eric Anderson Sr. Systems Administrator Centaur Technology A lost ounce of gold may be found, a lost moment of time never. ------------------------------------------------------------------------