Date: Fri, 3 Feb 2023 10:30:25 -0600 From: Kyle Evans <kevans@freebsd.org> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org> Cc: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>, rgrimes@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cb96a0ef0040 - main - cp: Minor code cleanup. Message-ID: <CACNAnaF2H3Af8_FP41-7MD2oGCGh_G=bo91ZPvz4HNj2G_ZLhw@mail.gmail.com> In-Reply-To: <86edr63ert.fsf@ltc.des.no> References: <202302031558.313Fw2sJ051540@gndrsh.dnsmgr.net> <86lele3f6c.fsf@ltc.des.no> <CACNAnaFF_yQDtdnDtUr7wz4NPsCmG5ODASopm8YvmZ_GF2TK2w@mail.gmail.com> <86edr63ert.fsf@ltc.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 3, 2023 at 10:16 AM Dag-Erling Sm=C3=B8rgrav <des@freebsd.org> = wrote: > > Kyle Evans <kevans@freebsd.org> writes: > > fts_read() doesn't always set errno to 0; notably, there's a number of > > FCHDIR() paths that don't set errno (and the change that added it > > mentions that scenario exactly) and will return NULL because of an > > error. > > The man page says it does, and as far as I can tell from the code it > does. Can you please provide a test case? > Ahh, I missed that FTS_NOCHDIR is set here.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaF2H3Af8_FP41-7MD2oGCGh_G=bo91ZPvz4HNj2G_ZLhw>