From owner-svn-ports-all@FreeBSD.ORG  Sun Apr 20 21:39:17 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 85FD8572;
 Sun, 20 Apr 2014 21:39:17 +0000 (UTC)
Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93])
 (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (Client CN "alln-iport.cisco.com", Issuer "Cisco SSCA2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2315B171B;
 Sun, 20 Apr 2014 21:39:16 +0000 (UTC)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AhQFAD4+VFOtJV2Y/2dsb2JhbABZgwZPxGKBHRZ0giUBAQU4PAQBEAsOCgkWDwkDAgECAUUGDQEFAgEBBYg4DcxZF45iB4Q4AQOaJYUhhimFToNNIQ
X-IronPort-AV: E=Sophos;i="4.97,894,1389744000"; d="scan'208";a="37291597"
Received: from rcdn-core-1.cisco.com ([173.37.93.152])
 by alln-iport-6.cisco.com with ESMTP; 20 Apr 2014 21:39:10 +0000
Received: from [10.117.46.169] (rtp-jclarke-8918.cisco.com [10.117.46.169])
 by rcdn-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id s3KLd9DX027010;
 Sun, 20 Apr 2014 21:39:10 GMT
Message-ID: <53543E7D.5050002@freebsd.org>
Date: Sun, 20 Apr 2014 17:39:09 -0400
From: Joe Marcus Clarke <marcus@freebsd.org>
Organization: FreeBSD, Inc.
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r351606 - head/net/netatalk
References: <201404191907.s3JJ7gAR096735@svn.freebsd.org>
 <20140420144833.GB89106@FreeBSD.org>
In-Reply-To: <20140420144833.GB89106@FreeBSD.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Apr 2014 21:39:17 -0000

On 4/20/14, 10:48 AM, Alexey Dokuchaev wrote:
> On Sat, Apr 19, 2014 at 07:07:42PM +0000, Joe Marcus Clarke wrote:
>> New Revision: 351606
>> URL: http://svnweb.freebsd.org/changeset/ports/351606
>> QAT: https://qat.redports.org/buildarchive/r351606/
>>
>> Log:
>>    * Convert to STAGE
>>    * Only enable AppleTalk support on versions of FreeBSD that support it [1]
>>
>> [...]
>> +APPLETALK_DESC=	AppleTalk protocol support (where supported)
>
> This change is bogus.  You could've simply make this option conditional.  For
> example, cf. games/doomlegacy:
>
> .if exists(/usr/include/netipx/ipx.h)
> OPTIONS_DEFINE+=	IPX
> IPX_DESC=	IPX protocol support
> .endif
>
>> -.if ${PORT_OPTIONS:MAPPLETALK}
>> +.if ${OSVERSION} < 1100013 && ${PORT_OPTIONS:MAPPLETALK}
>
> Is it possible to use exists() here instead of OSVERSION?  We're generally
> trying to get rid of OSVERSION checks...

Yeah, it looks like netatalk/ddp.h won't exist.

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome@FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome