From owner-svn-src-projects@FreeBSD.ORG Wed Jan 28 07:43:02 2015 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EF7BB434; Wed, 28 Jan 2015 07:43:02 +0000 (UTC) Received: from tensor.andric.com (unknown [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AAB3C993; Wed, 28 Jan 2015 07:43:02 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::a172:f359:fad3:822] (unknown [IPv6:2001:7b8:3a7:0:a172:f359:fad3:822]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 6983F5C2E; Wed, 28 Jan 2015 08:42:57 +0100 (CET) Subject: Re: svn commit: r277803 - projects/clang360-import/lib/clang/include Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_D524E557-6971-4AC2-9A6E-7902AC765974"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b4 From: Dimitry Andric In-Reply-To: <20150127191134.4fe3a17f@kan> Date: Wed, 28 Jan 2015 08:42:48 +0100 Message-Id: References: <201501271925.t0RJPem3010417@svn.freebsd.org> <20150127191134.4fe3a17f@kan> To: Alexander Kabaev X-Mailer: Apple Mail (2.2070.6) Cc: Benjamin Kaduk , svn-src-projects@freebsd.org, "src-committers@freebsd.org" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 07:43:03 -0000 --Apple-Mail=_D524E557-6971-4AC2-9A6E-7902AC765974 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 28 Jan 2015, at 01:11, Alexander Kabaev wrote: On Tue, 27 Jan 2015 14:34:21 -0500 > > Benjamin Kaduk wrote: > >> On Tue, Jan 27, 2015 at 2:25 PM, Dimitry Andric >> wrote: >> >>> Author: dim >>> Date: Tue Jan 27 19:25:39 2015 >>> New Revision: 277803 >>> URL: https://svnweb.freebsd.org/changeset/base/277803 >>> >>> Log: >>> Change the path to clang's private headers. Upstream has always >>> stored these in $LIBDIR/clang/$VERSION/include, instead of our >>> previous custom location in /usr/include/clang/$VERSION. This >>> allows us to drop yet another FreeBSD-specific patch. >>> >>> Modified: >>> projects/clang360-import/lib/clang/include/Makefile >>> >>> Modified: projects/clang360-import/lib/clang/include/Makefile >>> > > I think spreading .h files all over the tree is actually a regression. I'm not sure what the problem is with storing a compiler's internal-only headers in the location where upstream expects them to be? Note that gcc does something similar; for example with the gcc49 port, it stores all its internal headers under: /usr/local/lib/gcc49/gcc/i386-portbld-freebsd11.0/4.9.3/include While I do agree that this is not a pretty-looking path, upstream has chosen it to be like this, and there are most likely good reasons for it. As for clang, I just want to get rid of as many "FreeBSD is a special snowflake" patches as I can. -Dimitry --Apple-Mail=_D524E557-6971-4AC2-9A6E-7902AC765974 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlTIkwEACgkQsF6jCi4glqNVqwCdGeD8q9V3cuZQvam856JsQMPp pt4AoN435R9/B/brEMTxB/2bnDDexPnM =3jzI -----END PGP SIGNATURE----- --Apple-Mail=_D524E557-6971-4AC2-9A6E-7902AC765974--