From owner-svn-src-all@FreeBSD.ORG  Mon Apr 16 19:42:00 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A7519106566B
	for <svn-src-all@freebsd.org>; Mon, 16 Apr 2012 19:42:00 +0000 (UTC)
	(envelope-from juli@clockworksquid.com)
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
	[209.85.212.178])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E6E18FC15
	for <svn-src-all@freebsd.org>; Mon, 16 Apr 2012 19:42:00 +0000 (UTC)
Received: by wibhq7 with SMTP id hq7so4612076wib.13
	for <svn-src-all@freebsd.org>; Mon, 16 Apr 2012 12:41:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type
	:content-transfer-encoding:x-gm-message-state;
	bh=rNmGkBvCQJUVk9lqxQTO7VxH8nHjrb82rKjZaTy/4fw=;
	b=YbHS3i/gNnAXL9DyzhgQ0AmJJCsGp/CwTgrAB2J4/wTmgsiKMUSt9lpLKcmdztJi2I
	SoejMggSG+JwoswuNYfQi4CcF0EVx5rT37OvpBE6SGUpt1q3HxJpw/ttuPMeaWtmc/rE
	Ni56hzLUvTgU1NDwMnV50dD7ZVhAZ3Grrjq5Oovpqml1ifavHt2QxHhL/6Si5IfizDPd
	PpsHTldCltZEQnv/vePMuPxjhXhcjxbFPtC710U0JmTtMhw5BKQBCm7W+irATNSHI/Kf
	AVa51czB+ojJVDtdkofp4I9iWpww9SzSF14MPz2eJUzorTxeZ3THYFOSSisVel0aqEmD
	e+dg==
Received: by 10.180.94.161 with SMTP id dd1mr21591909wib.16.1334605318948;
	Mon, 16 Apr 2012 12:41:58 -0700 (PDT)
MIME-Version: 1.0
Sender: juli@clockworksquid.com
Received: by 10.216.212.157 with HTTP; Mon, 16 Apr 2012 12:41:38 -0700 (PDT)
In-Reply-To: <201204160938.q3G9cLmw026093@svn.freebsd.org>
References: <201204160938.q3G9cLmw026093@svn.freebsd.org>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Mon, 16 Apr 2012 12:41:38 -0700
X-Google-Sender-Auth: e-epkAv2KQ4NhIlF7igzh7EQC6I
Message-ID: <CACVs6=8BYYN0ZW7zzHZduns-ZH9hUF=M1EmXfoOkCZVMh1ubpg@mail.gmail.com>
To: Andrew Turner <andrew@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Gm-Message-State: ALoCoQmrFyieX2JGR4EcsIt2PBooB+6C4EyP8+MUSbjz4bYZe9Gb29A7cMTxwELve2OMAlDs1x79
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r234337 - in head: lib/libc/arm/gen sys/arm/include
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2012 19:42:00 -0000

On Mon, Apr 16, 2012 at 02:38, Andrew Turner <andrew@freebsd.org> wrote:
> Log:
> =C2=A0Replace the C implementation of __aeabi_read_tp with an assembly ve=
rsion.
> =C2=A0This ensures we follow the ABI by preserving registers r1-r3.

> +ENTRY(__aeabi_read_tp)
> + =C2=A0 =C2=A0 =C2=A0 ldr =C2=A0 =C2=A0 r0, .Larm_tp_address
> + =C2=A0 =C2=A0 =C2=A0 ldr =C2=A0 =C2=A0 r0, [r0]
> + =C2=A0 =C2=A0 =C2=A0 RET
> +
> +.Larm_tp_address:
> + =C2=A0 =C2=A0 =C2=A0 .word ARM_TP_ADDRESS
> +

Why is this indirection required?  Can't you just use ARM_TP_ADDRESS
instead of loading it from data?  Also, is our convention for ARM to
use END() with ENTRY() or not?