Date: Mon, 16 Apr 2012 12:41:38 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Andrew Turner <andrew@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r234337 - in head: lib/libc/arm/gen sys/arm/include Message-ID: <CACVs6=8BYYN0ZW7zzHZduns-ZH9hUF=M1EmXfoOkCZVMh1ubpg@mail.gmail.com> In-Reply-To: <201204160938.q3G9cLmw026093@svn.freebsd.org> References: <201204160938.q3G9cLmw026093@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 16, 2012 at 02:38, Andrew Turner <andrew@freebsd.org> wrote: > Log: > =C2=A0Replace the C implementation of __aeabi_read_tp with an assembly ve= rsion. > =C2=A0This ensures we follow the ABI by preserving registers r1-r3. > +ENTRY(__aeabi_read_tp) > + =C2=A0 =C2=A0 =C2=A0 ldr =C2=A0 =C2=A0 r0, .Larm_tp_address > + =C2=A0 =C2=A0 =C2=A0 ldr =C2=A0 =C2=A0 r0, [r0] > + =C2=A0 =C2=A0 =C2=A0 RET > + > +.Larm_tp_address: > + =C2=A0 =C2=A0 =C2=A0 .word ARM_TP_ADDRESS > + Why is this indirection required? Can't you just use ARM_TP_ADDRESS instead of loading it from data? Also, is our convention for ARM to use END() with ENTRY() or not?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACVs6=8BYYN0ZW7zzHZduns-ZH9hUF=M1EmXfoOkCZVMh1ubpg>