From owner-cvs-all Mon Mar 4 16:54:38 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id F052837B402; Mon, 4 Mar 2002 16:54:29 -0800 (PST) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id g250sUM38227; Mon, 4 Mar 2002 16:54:30 -0800 (PST) (envelope-from obrien) Date: Mon, 4 Mar 2002 16:50:27 -0800 From: "David O'Brien" To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys random.h src/sys/dev/random harvest.c hash.c hash.h randomdev.c randomdev.h yarrow.c Message-ID: <20020304165027.A38109@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200203031944.g23JiMj39565@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200203031944.g23JiMj39565@freefall.freebsd.org>; from markm@FreeBSD.org on Sun, Mar 03, 2002 at 11:44:22AM -0800 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Mar 03, 2002 at 11:44:22AM -0800, Mark Murray wrote: > markm 2002/03/03 11:44:22 PST > > Modified files: > sys/sys random.h > sys/dev/random harvest.c hash.c hash.h randomdev.c > randomdev.h yarrow.c > Log: > Massive lint-inspired cleanup. > Remove unneeded includes. > Deal with unused function arguments. > Resolve a boatload of signed/unsigned imcompatabilities. - for (i = 0; i < count; i+= sizeof(u_long)) { + for (i = 0; i < count; i+= (size_t)sizeof(u_long)) { Why is this needed?? sizeof already has a type of "size_t". This looks like more obfuscation just to quiet Lint. ISO-C99 says: 6.5.3.4 The _sizeof_ operator 4 The value of the result is implementation-defined, and its type (an unsigned integer type) is `size_t', defined in `' (and other headers). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message