From owner-p4-projects@FreeBSD.ORG  Thu Nov 19 23:16:23 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 38D2B106568D; Thu, 19 Nov 2009 23:16:23 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F0D9B1065676
	for <perforce@FreeBSD.org>; Thu, 19 Nov 2009 23:16:22 +0000 (UTC)
	(envelope-from nwhitehorn@freebsd.org)
Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119])
	by mx1.freebsd.org (Postfix) with ESMTP id C746B8FC18
	for <perforce@FreeBSD.org>; Thu, 19 Nov 2009 23:16:22 +0000 (UTC)
Received: from localhost (localhost.localdomain [127.0.0.1])
	by mail.icecube.wisc.edu (Postfix) with ESMTP id A3D04581BD;
	Thu, 19 Nov 2009 16:48:00 -0600 (CST)
X-Virus-Scanned: amavisd-new at icecube.wisc.edu
Received: from mail.icecube.wisc.edu ([127.0.0.1])
	by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new,
	port 10030)
	with ESMTP id mWRqF4FJjttM; Thu, 19 Nov 2009 16:48:00 -0600 (CST)
Received: from wanderer.tachypleus.net
	(i3-dhcp-172-16-223-119.icecube.wisc.edu [172.16.223.119])
	by mail.icecube.wisc.edu (Postfix) with ESMTP id 8617D58176;
	Thu, 19 Nov 2009 16:48:00 -0600 (CST)
Message-ID: <4B05CB1F.8020100@freebsd.org>
Date: Thu, 19 Nov 2009 16:47:59 -0600
From: Nathan Whitehorn <nwhitehorn@freebsd.org>
User-Agent: Thunderbird 2.0.0.23 (X11/20090909)
MIME-Version: 1.0
To: Hans Petter Selasky <hselasky@FreeBSD.org>
References: <200911192235.nAJMZ2XH072195@repoman.freebsd.org>
In-Reply-To: <200911192235.nAJMZ2XH072195@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 170842 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Nov 2009 23:16:23 -0000

Hans Petter Selasky wrote:
> http://p4web.freebsd.org/chv.cgi?CH=170842
>
> Change 170842 by hselasky@hselasky_laptop001 on 2009/11/19 22:34:49
>
> 	
> 	USB input:
> 		 - ATP patch from Rohit Grover:
> 		   - fixes some minor issues and
> 		     makes the control transfer
> 		     fully asynchronous
>
>
>   
[...]
> @@ -1530,7 +1574,7 @@
>  		return (ENXIO);
>  
>  	if (usbd_lookup_id_by_uaa(atp_devs, sizeof(atp_devs), uaa) == 0)
> -		return BUS_PROBE_SPECIFIC;
> +		return 0;
>  	else
>  		return ENXIO;
>  }
Why are you replacing symbolic constants with less informative numeric ones?
-Nathan