Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 19 Feb 2011 21:31:03 +0100
From:      Martin Birgmeier <la5lbtyi@aon.at>
To:        freebsd-net@freebsd.org
Subject:   Locking in ng_tty.c
Message-ID:  <4D602887.8010204@aon.at>
next in thread | raw e-mail | index | archive | help 
In ng_tty.c, function ngt_newhook(), there is the following code:

         if (sc->hook)
                 return (EISCONN);

         NGTLOCK(sc);
         sc->hook = hook;
         NGTUNLOCK(sc);

I do not think this is proper - should not the test be within the lock?

Regards,

Martin

-- 
Martin Birgmeier
Vienna
Austria

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D602887.8010204>