From owner-svn-ports-all@FreeBSD.ORG Mon Jul 30 15:56:14 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4C9811065674; Mon, 30 Jul 2012 15:56:14 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.lysator.liu.se (mail.lysator.liu.se [IPv6:2001:6b0:17:f0a0::3]) by mx1.freebsd.org (Postfix) with ESMTP id B98328FC19; Mon, 30 Jul 2012 15:56:13 +0000 (UTC) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id C741B40006; Mon, 30 Jul 2012 17:56:12 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id BD5DA40005; Mon, 30 Jul 2012 17:56:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL autolearn=disabled version=3.3.1 X-Spam-Score: 0.0 Received: from mx.daemonic.se (mx.daemonic.se [IPv6:2001:470:dca9:0:1::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 4EDCA40003; Mon, 30 Jul 2012 17:56:12 +0200 (CEST) Received: from mailscanner.daemonic.se (mailscanner.daemonic.se [IPv6:2001:470:dca9:0:1::6]) by mx.daemonic.se (Postfix) with ESMTPS id 3Wm53v72vjz8gtM; Mon, 30 Jul 2012 17:56:11 +0200 (CEST) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mx.daemonic.se ([IPv6:2001:470:dca9:0:1::3]) (using TLS with cipher CAMELLIA256-SHA) by mailscanner.daemonic.se (mailscanner.daemonic.se [2001:470:dca9:0:1::6]) (amavisd-new, port 10025) with ESMTPS id NrTn3413lYCE; Mon, 30 Jul 2012 17:56:06 +0200 (CEST) Received: from mail.daemonic.se (mail.daemonic.se [IPv6:2001:470:dca9:0:1::4]) by mx.daemonic.se (Postfix) with ESMTPS id 3Wm53p2PXMz8gtL; Mon, 30 Jul 2012 17:56:06 +0200 (CEST) Received: from tifa.daemonic.se (tifa.daemonic.se [IPv6:2001:470:dca9:1::6]) by mail.daemonic.se (Postfix) with ESMTPSA id 3Wm53p1qHPz9Ctj; Mon, 30 Jul 2012 17:56:06 +0200 (CEST) Received: from tifa.daemonic.se (localhost [IPv6:::1]) by tifa.daemonic.se (Postfix) with ESMTP id 14D51228F5; Mon, 30 Jul 2012 17:56:06 +0200 (CEST) Message-ID: <5016AE95.4090805@freebsd.org> Date: Mon, 30 Jul 2012 17:56:05 +0200 From: Niclas Zeising User-Agent: Mutt/1.5.21 MIME-Version: 1.0 To: Bryan Drewery References: <201207301530.q6UFUaOr007302@svn.freebsd.org> <5016AACF.5090700@shatow.net> In-Reply-To: <5016AACF.5090700@shatow.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r301719 - head/databases/aolserver-nspostgres X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2012 15:56:14 -0000 On 07/30/12 17:39, Bryan Drewery wrote: > This is not the patch I sent in. > > As I said in the PR, I purposely moved DISTVERSIONSUFFIX to fix a > portlint error, which still exists now. > > # portlint . > FATAL: Makefile: DISTVERSIONSUFFIX appears out-of-order. > FATAL: Makefile: order must be > PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY. > 2 fatal errors and 0 warnings found. Me and my mentor decided that it made more sense to keep DISTVERSIONSUFFIX where it is, since it is connected to the name of the port. Looking closely at the output of portlint, DISTVERSIONSUFFIX should really be *before* PORTREVISION, not halfway down the makefile. That portlint grows quiet when it is put there is arguably a bug in portlint. > > Adding USE_LDCONFIG may change behavior as well. I had left it out as I > had not tested it yet. It is my understanding that all ports that install shared libraries should have USE_LDCONFIG=yes in their makefile. Portlint tells you as much if I am not mistaken. -- Niclas Zeising