From owner-freebsd-cvsweb  Sat Sep  7 13: 6:20 2002
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 79D0D37B400
	for <freebsd-cvsweb@FreeBSD.org>; Sat,  7 Sep 2002 13:06:17 -0700 (PDT)
Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6A23143E3B
	for <freebsd-cvsweb@FreeBSD.org>; Sat,  7 Sep 2002 13:06:16 -0700 (PDT)
	(envelope-from scop@FreeBSD.org)
Received: from cs78131139.pp.htv.fi ([62.78.131.139])
	by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id g87K6e614532;
	Sat, 7 Sep 2002 23:06:40 +0300 (EETDST)
Subject: Re: FW: Unlimited redirect  - CGI wrapper / Contribute Code
From: Ville =?ISO-8859-1?Q?Skytt=E4?= <scop@FreeBSD.org>
To: Lance Rushing <lance@lancerushing.com>
Cc: freebsd-cvsweb@FreeBSD.org
In-Reply-To: <NEBBLHBOGAFGANFIFDEAMEOJCKAA.lance@lancerushing.com>
References: <NEBBLHBOGAFGANFIFDEAMEOJCKAA.lance@lancerushing.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-Mailer: Ximian Evolution 1.0.3 (1.0.3-6) 
Date: 07 Sep 2002 23:06:14 +0300
Message-Id: <1031429174.1744.10.camel@bobcat.ods.org>
Mime-Version: 1.0
Sender: owner-freebsd-cvsweb@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-cvsweb.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-cvsweb>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-cvsweb>
X-Loop: FreeBSD.ORG

On Sat, 2002-09-07 at 11:46, Lance Rushing wrote:

> I modified cvsweb.cgi to work with a cgi wrapper (specifically for a Coba=
lt
> RaQ4)
>=20
> Should/Where/How/Who I should contact to add this change to the cvsweb
> project?

Hello Lance, thanks for the patch, the freebsd-cvsweb mailing list is
the correct place.

However, I haven't applied your patch yet, basically because I see it
somewhat hacky, especially the portion of detecting cgiwrap based on
directory/file name.  Could you post the full contents of %ENV of
cvsweb.cgi running under cgiwrap, so we could see if there's something
else there to base the detection on?

In case there isn't, I think I will apply this, but add a configuration
variable for enabling that stuff, and default it to false.

> Here is a diff output for the pertinent stuff.
>=20
> 259a260,262
> > $scriptname =3D defined($ENV{SCRIPT_NAME}) ? $ENV{SCRIPT_NAME} : '';
> > $scriptname =3D~ s|^/*|/|;
> 260a264,277
> >
> > my $scriptfilename    =3D defined($ENV{SCRIPT_FILENAME}) ?
> $ENV{SCRIPT_FILENAME} : '';
> > if ($scriptfilename =3D~ m|^/usr/cgiwrap/cgiwrap$|) {
> >       #Example ENV values one cgi wrapper
> >       #$ENV{PATH_TRANSLATED} =3D
> /home/sites/site35/web/cgi-bin/cvsweb-2.0.5/cvsweb.cgi
> >       #$ENV{PATH_INFO} =3D /cgi-bin/cvsweb-2.0.5/cvsweb.cgi/CVSROOT/
> >       #$ENV{SCRIPT_NAME} =3D /cgi-bin/cvsweb-2.0.5/cvsweb.cgi/CVSROOT/
> >
> >       my $myname      =3D defined($ENV{PATH_TRANSLATED}) ?
> $ENV{PATH_TRANSLATED} : '';
> >       $myname         =3D~ s|^.*/||;
> >       $scriptname     =3D~ s|^(.*$myname).*$|$1|;
> >       $pathinfo       =3D~ s|$scriptname||;
> > }
> >
> 265,266c282
> < $scriptname =3D defined($ENV{SCRIPT_NAME}) ? $ENV{SCRIPT_NAME} : '';
> < $scriptname =3D~ s|^/*|/|;

Cheers,
--=20
\/ille Skytt=E4
scop at FreeBSD.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-cvsweb" in the body of the message