From owner-freebsd-ports@FreeBSD.ORG Tue Jan 13 15:32:51 2015 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 758E1690 for ; Tue, 13 Jan 2015 15:32:51 +0000 (UTC) Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [212.27.42.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 38787EAC for ; Tue, 13 Jan 2015 15:32:50 +0000 (UTC) Received: from shell.bebik.local (unknown [78.194.61.125]) by smtp1-g21.free.fr (Postfix) with ESMTP id 606FB940128; Tue, 13 Jan 2015 16:31:01 +0100 (CET) Received: from shell.bebik.local ([192.168.1.101]) by shell.bebik.local (8.14.5/8.14.5) with ESMTP id t0DFTP9t036889; Tue, 13 Jan 2015 15:29:25 GMT (envelope-from rodrigo@shell.bebik.local) Received: (from rodrigo@localhost) by shell.bebik.local (8.14.5/8.14.5/Submit) id t0DFTPiQ036888; Tue, 13 Jan 2015 15:29:25 GMT (envelope-from rodrigo) Date: Tue, 13 Jan 2015 15:29:24 +0000 From: Rodrigo Osorio To: Chris H Subject: Re: getpatch scripit rewroted in plain shell Message-ID: <20150113152914.GA34923@shell.bebik.local> References: <20150113134931.GA27220@shell.bebik.local> <31b09270cbbd866005dca3e1584f3f9c@ultimatedns.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <31b09270cbbd866005dca3e1584f3f9c@ultimatedns.net> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2015 15:32:51 -0000 On 13/01/15 07:11 -0800, Chris H wrote: > On Tue, 13 Jan 2015 13:49:31 +0000 Rodrigo Osorio wrote > > > Hi ports :) > > > > For a long time, I was missing some features in the exising getpatch script > > ( svn repo Tools/scripts/getpatch) and since I'm not a py fan boy, I rewrote > > the tool in plain shell. This is its storry.... > > > > The new features are : > > - use the bug id as a directory to store the attachements inside (can be > > turned off) - decide if you want or not obsolete patches (by default is no) > > - an env variable to define where attachements are stored (by default ./) > > - be verbose > > - only uses tools from base > > > > example : > > rodrigo@scotty % printenv GETPATCH_DIR > > /home/rodrigo/patches/ > > > > rodrigo@scotty % getpatch 191840 > > Bug ID: 191840 > > + att-144615: pidgin-gnome-keyring.tar.gz is obsolete, skip > > + att-144641: pidgin-gnome-keyring.tar.gz download success > > + att-144642: pidgin-gnome-keyring-1.20_1.txz download success > > >> Patches stored in /usr/home/rodrigo/patches/191840 > > > > The code is here : http://files.bebik.net/code/getpatch > > > > Suggestions and comments are wellcomed > Looks good. > Your native language appears to be français. :) > I would only offer grammatical changes: > > s/a dedicate/the dedicated/g > > s/dedicate/dedicated/g > > # I try to avoid contractions because some shells trip on the apostrophe. > s/Can\'t/Unable to/g > > s/catched/caught/g > > Bon travail! > > --Chris > > > > Regards, > > - rodrigo > > > > PS: There are room for improvements, I know. Bugzilla request can be reduced > > to a single one but this leads to xml and b64 management in shell, and it > > sounds a little bit insane to me... > > > > _______________________________________________ > > freebsd-ports@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" > > Chris, Thanks for your feedback, I really appreciate your contribution. The file now includes the suggested changes. - rodrigo