From owner-freebsd-ports@freebsd.org Mon May 9 06:37:22 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51765B3428C for ; Mon, 9 May 2016 06:37:22 +0000 (UTC) (envelope-from ganbold@gmail.com) Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 179E212A7 for ; Mon, 9 May 2016 06:37:22 +0000 (UTC) (envelope-from ganbold@gmail.com) Received: by mail-oi0-x236.google.com with SMTP id v145so199588943oie.0 for ; Sun, 08 May 2016 23:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=cDAPPRXvjMP585uPojL6masU5MBsoa0TXSSiTOIFZgU=; b=LDpiIM+imM1c1uy16NFBLGS49QCzuDv5jh25I37NyFbzRL2pD5SMxBZKzvVkM+s+9f YlxjviCqzNof8/KcMntdtgnu+NT6od9WdRKRPEx/eJnK6my214M06tO7cIKKAnvJem29 g3zeLFU7qfNPWqjFr7HLJLb1vjscQUFPG5WycGfoWLTHxI8Brz3kTSaveIDZz1GJTkeo DnTZSkJ1oarabWXB1r52bh24QzGmTcQaXf9NC5lGUhgnbSa3XEcRv0qV9EqVn8znzKsR C9XPDhhWQBuJCHKb0T484qFZ+nlaL0XBr74KRo/ozoIuV/FYOegrgCyzXfM1XmnzkzFw z93g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=cDAPPRXvjMP585uPojL6masU5MBsoa0TXSSiTOIFZgU=; b=TpgNjWPnUMJDnIseQSQDIDgCnvR6+6Dr3zX3ZaGHCsdE2S9LptRet+J8MaBXrwL2+Z imW9OZa31rzIS0RIvtNcI+V61PIbeJ3hOpoJ7iOCD6a4VwfnJyZLdQ1S+WBOrQECn9xO 2GCeQ0d8Z5gWsAZy1uYPmY5AjvuQO8SsNiSUMfn+igBYYxI/vfapwX3yvlqXgNWtcXpz jz7D/hs7PP0RxPy+EXS8/u6bdgxoKVYJyURBQuVNNCf3ZKcHO3Zt2FwECpnlYaWphIPJ 1BLm/fFy80LqDPcmv9qlh1O6dPtjbKjGZDTkvWv+kyxhzsJkhTENhsSgRL2OFV/YHBnU tveQ== X-Gm-Message-State: AOPr4FU+fZE7A+CDX6Mqv1qcKP0WWO+dwrH8KFoKVKN8H2ce7qASYXDFKfmB6VZPGdWqCh/yt6uwYzFPHJwaOQ== MIME-Version: 1.0 X-Received: by 10.202.232.206 with SMTP id f197mr14670311oih.182.1462775841268; Sun, 08 May 2016 23:37:21 -0700 (PDT) Received: by 10.182.158.66 with HTTP; Sun, 8 May 2016 23:37:21 -0700 (PDT) In-Reply-To: References: <20160507070925.GA2295@home.opsec.eu> Date: Mon, 9 May 2016 15:37:21 +0900 Message-ID: Subject: Re: new port for review: LDAP Authenticator plugin for MySQL From: Ganbold Tsagaankhuu To: Kurt Jaeger Cc: freebsd-ports@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2016 06:37:22 -0000 Hi, On Sun, May 8, 2016 at 12:28 PM, Ganbold Tsagaankhuu wrote: > Hi, > > On Sat, May 7, 2016 at 4:09 PM, Kurt Jaeger wrote: > >> Hi! >> >> > Can anyone take a look or review new port at >> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208913 ? >> > This is LDAP Authenticator plugin for MySQL. >> >> One important thing: new ports should be submitted as shar-file. >> >> There are several issues, which running >> >> cd >> portlint -AC >> >> flags. > > > > In my case portent -AC shows "pkg-descr: exceeds 24 lines, make it shorter > if possible.(currently 39 lines)" > I will fix that. > > > >> One other thing that sticks out: Is it really necessary to have >> the ateam prefix for the port ? >> > > > Yes, we can't remove the A-Team part because then the project name is > basically the same as the project we forked. We need it there to > differentiate. > I'm open to discuss on the name of the port, initially I thought it would be better to have different name than the original project. Please let me know. thanks, Ganbold > > > >> >> I've added a shar of the modified port to the PR, which still >> does not yet fetch and build. Can you provide a version 1.0 >> on github that we can fetch ? >> > > > Should it necessarily does have version 1.0 in github? Can't it > use GH_TAGNAME ? > > thanks, > > Ganbold > > > >> >> Btw, I've created the shar with: >> >> shar `find mysql-ldap-auth -print` > /tmp/ldap.shar >> >> -- >> pi@opsec.eu +49 171 3101372 4 years >> to go ! >> > >