From owner-svn-src-all@freebsd.org Mon Oct 23 15:08:28 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 379A9E4DDA4 for ; Mon, 23 Oct 2017 15:08:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EB96673875 for ; Mon, 23 Oct 2017 15:08:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22e.google.com with SMTP id i38so20445516iod.2 for ; Mon, 23 Oct 2017 08:08:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1XLo38yCUo9OXhzFm9ok1dbzCGu/tnihPpqCMX3p+2c=; b=GSRMYIRNEt8KUz6saGzvuBn88Ymzw3jyVOVTayk3BKMjlhuAjIAh6IkmWaaTNwHE/+ kAFmJsiGcXTKl2Wn0Hm1Kw3Wnsv+lyrycNwLGYUy2kLN2Q+aNIariHw2H62IWjE0qdp1 1Ve0Qgn/JAnnGb3VOcf2nMQACVCNvAaYtx1Unz0OQH1xC7OyV0Fa0cd3Bot/4VPs62Ni 5wQlI9gsy8YgfGK8WTkSC2O6kzy3RzlIOTmABcw3Z2k+0elgp4eAWF/ZUQkhrI1hnl4P CpuVcqEfzrDi3H5LMhTAcY1+w+uGce6C/M+B55jQp5fFh7SVxbdhUIqW2R2z5KeGSZNF SmoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1XLo38yCUo9OXhzFm9ok1dbzCGu/tnihPpqCMX3p+2c=; b=DP+XzRXrSHR9+oKty6cMUl0Y6uRJi0MNQDe+5ZWoMgFnz19woNTIaRayMuvPbm9mfs DLkwpeRU5dj0nkAU7ziCgVlDeZdSGi16t33h1zTRPeosrFLLN0N+7CpJQqupLuL8AmZn z4CzZv6pRXpwINUbhCQiY56ROayTr5MS3Ibm4mlSoDSSWYrIgEhDEU8yZME2T9rJMKxS mw7KXQdnuYpNXFPihApZCHjy33MmnRtY/CtVW2f0Jb9sbsgj7rV900DNjaJ0N4VxNOEm rUzY4sUnINyiOlx/TUQgovNkR8pNCYbUKME82DS3fGmlGLSGTy17v23FMNVhj76OaMqe TrpQ== X-Gm-Message-State: AMCzsaVfqHZA7opD1XtY/FLkyEVcCKBGfsfmsEJ/I4eyWQd94Vgotaxu YPAB2G/DSEZX5s/rhOG2ZINyH5DvhzItonRPfxhpIA== X-Google-Smtp-Source: ABhQp+RwEtr2RvOyjgfOBhblZjIoN6cKy4a8VTEzy3LtLpWQzWSThJYJZk/aHZ6IGXQ7sl6WZ6S432cWlyDwgbnJUoY= X-Received: by 10.107.81.21 with SMTP id f21mr16484279iob.63.1508771307152; Mon, 23 Oct 2017 08:08:27 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.57.22 with HTTP; Mon, 23 Oct 2017 08:08:26 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:df5:793f:4458:5cf6] In-Reply-To: References: <201710230756.v9N7uujL028775@repo.freebsd.org> <20171023084847.GN2473@kib.kiev.ua> <11B333F5-0899-4AD8-9F90-2002C3C2359A@gmail.com> From: Warner Losh Date: Mon, 23 Oct 2017 09:08:26 -0600 X-Google-Sender-Auth: ZZs6ebwToZXqzy_WddVbfRY7qAA Message-ID: Subject: Re: svn commit: r324911 - head/share/mk To: Justin Hibbits Cc: Garrett Cooper , Konstantin Belousov , Ngie Cooper , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 15:08:28 -0000 On Mon, Oct 23, 2017 at 7:09 AM, Justin Hibbits wrote: > On Oct 23, 2017 07:57, "Ngie Cooper" wrote: > > > > On Oct 23, 2017, at 01:48, Konstantin Belousov > wrote: > > > >> On Mon, Oct 23, 2017 at 07:56:56AM +0000, Ngie Cooper wrote: > >> Author: ngie > >> Date: Mon Oct 23 07:56:56 2017 > >> New Revision: 324911 > >> URL: https://svnweb.freebsd.org/changeset/base/324911 > >> > >> Log: > >> Fix an omission in a comment > >> > >> Soft float API support applies to armv7 too after r324340 > > Does it ? From my understanding, requiring hw float was one of the > > reason for armv7 appearance. > > Hah... the comment=E2=80=99s backwards. Classic! > > > It was my understanding that armv{6,7} use the softfloat ABI but still > require a hardware float. > No. Thats not true in FreeBSD 11 and newer. Hard float with hard float ABI is the default, although we can compile armv7 with soft floating point ABI using either software fp or hardware fp. These libraries are meant to bridge the gap between the two worlds, though the armv7 stuff is largely untested. The comment isn't backwards at all. We only do LIBSOFT on amrv6/7. That's why we mark it 'BROKEN' on the other architectures so we don't try it at all. Though mips is a good candidate for it. Warner > - Justin > > > >> > >> Modified: > >> head/share/mk/src.opts.mk > >> > >> Modified: head/share/mk/src.opts.mk > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> --- head/share/mk/src.opts.mk Mon Oct 23 07:52:16 2017 (r324910) > >> +++ head/share/mk/src.opts.mk Mon Oct 23 07:56:56 2017 (r324911) > >> @@ -271,7 +271,7 @@ __DEFAULT_NO_OPTIONS+=3DGDB_LIBEXEC > >> .else > >> __DEFAULT_YES_OPTIONS+=3DGDB_LIBEXEC > >> .endif > >> -# Only doing soft float API stuff on armv6 > >> +# Only doing soft float API stuff on armv6 and armv7 > >> .if ${__T} !=3D "armv6" && ${__T} !=3D "armv7" > >> BROKEN_OPTIONS+=3DLIBSOFT > >> .endif > > >