From owner-cvs-src-old@FreeBSD.ORG Wed Apr 14 22:07:42 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84BA1106566C for ; Wed, 14 Apr 2010 22:07:42 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 7169D8FC12 for ; Wed, 14 Apr 2010 22:07:42 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o3EM7g1p006742 for ; Wed, 14 Apr 2010 22:07:42 GMT (envelope-from delphij@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o3EM7g7L006741 for cvs-src-old@freebsd.org; Wed, 14 Apr 2010 22:07:42 GMT (envelope-from delphij@repoman.freebsd.org) Message-Id: <201004142207.o3EM7g7L006741@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to delphij@repoman.freebsd.org using -f From: Xin LI Date: Wed, 14 Apr 2010 22:02:19 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ifconfig ifconfig.c src/share/man/man4 netintro.4 src/sys/net if.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2010 22:07:42 -0000 delphij 2010-04-14 22:02:19 UTC FreeBSD src repository Modified files: sbin/ifconfig ifconfig.c share/man/man4 netintro.4 sys/net if.c Log: SVN rev 206637 on 2010-04-14 22:02:19Z by delphij When an underlying ioctl(2) handler returns an error, our ioctl(2) interface considers that it hits a fatal error, and will not copyout the request structure back for _IOW and _IOWR ioctls, keeping them untouched. The previous implementation of the SIOCGIFDESCR ioctl intends to feed the buffer length back to userland. However, if we return an error, the feedback would be defeated and ifconfig(8) would trap into an infinite loop. This commit changes SIOCGIFDESCR to set buffer field to NULL to indicate the previous ENAMETOOLONG case. Reported by: bschmidt MFC after: 2 weeks Revision Changes Path 1.153 +12 -11 src/sbin/ifconfig/ifconfig.c 1.29 +6 -3 src/share/man/man4/netintro.4 1.381 +3 -4 src/sys/net/if.c