From owner-freebsd-hackers@FreeBSD.ORG Fri Apr 25 09:50:35 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD2AF1065670; Fri, 25 Apr 2008 09:50:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay01.kiev.sovam.com (relay01.kiev.sovam.com [62.64.120.200]) by mx1.freebsd.org (Postfix) with ESMTP id 2A8F08FC1C; Fri, 25 Apr 2008 09:50:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=skuns.kiev.zoral.com.ua) by relay01.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1JpKZa-0004Cr-3y; Fri, 25 Apr 2008 12:50:32 +0300 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m3P9oFFF013160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Apr 2008 12:50:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m3P9oADv010851; Fri, 25 Apr 2008 12:50:10 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m3P9o92T010850; Fri, 25 Apr 2008 12:50:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 25 Apr 2008 12:50:09 +0300 From: Kostik Belousov To: Andriy Gapon Message-ID: <20080425095009.GD18958@deviant.kiev.zoral.com.ua> References: <480E4269.2090604@icyb.net.ua> <480FBAB9.1000904@icyb.net.ua> <48103F36.6060707@icyb.net.ua> <200804240811.26183.jhb@freebsd.org> <4810FD1E.70602@icyb.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Xc2zRdLclVh020+J" Content-Disposition: inline In-Reply-To: <4810FD1E.70602@icyb.net.ua> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.4 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on skuns.kiev.zoral.com.ua X-Scanner-Signature: 717fb1dce93df3d9117221529acf11a8 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2719 [Apr 24 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release Cc: freebsd-hackers@freebsd.org Subject: Re: devctl (alike?) for devfs X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2008 09:50:35 -0000 --Xc2zRdLclVh020+J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 25, 2008 at 12:35:26AM +0300, Andriy Gapon wrote: >=20 > I decided to do it in devfs_devs.c because there are less entry points > there and the code is much simpler (you know: aliases, clones). > I also had to add !cold condition, because apparently we have devices > created so early in the boot, that devctl is not ready to handle a > notification. My system hanged after only getting to the following line > in verbose boot: > ULE: setup cpu 0 > However it is possible that it did something wrong - at that time I had > devctl calls in kern_conf. >=20 > I guess this also should be OK from the user perspective because they > would be interested in device events after a system is booted and devd > is running. >=20 > Here is a log of devd started with -dD flags in single-user mode, then I > attached and later detached an external hdd: > http://www.icyb.net.ua/~avg/devd.log.gz > Search for DEVFS for interesting lines. >=20 > --=20 > Andriy Gapon > diff --git a/sys/fs/devfs/devfs_devs.c b/sys/fs/devfs/devfs_devs.c > index ca5c2de..3556799 100644 > --- a/sys/fs/devfs/devfs_devs.c > +++ b/sys/fs/devfs/devfs_devs.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -518,6 +519,9 @@ devfs_create(struct cdev *dev) > dev_refl(dev); > TAILQ_INSERT_TAIL(&cdevp_list, cdp, cdp_list); > devfs_generation++; > + > + if (!cold) > + devctl_notify("DEVFS", dev->si_name, "ATTACH", NULL); > } > =20 > void > @@ -529,6 +533,9 @@ devfs_destroy(struct cdev *dev) > cdp =3D dev->si_priv; > cdp->cdp_flags &=3D ~CDP_ACTIVE; > devfs_generation++; > + > + if (!cold) > + devctl_notify("DEVFS", dev->si_name, "DETACH", NULL); > } > =20 > static void Did you run this with WITNESS ? You put the whole devctl_notify() call under the dev_mtx. This includes the malloc(), PROC_LOCK() and signalling, and some internal devctl_queue() stuff. This is wrong. --Xc2zRdLclVh020+J Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAkgRqVEACgkQC3+MBN1Mb4hTrgCeLqWrGFHU2nVieITScAHlZL6x f5UAoJ8tOstn8GmRE2XbmmUDv0yeO3lf =9Tr4 -----END PGP SIGNATURE----- --Xc2zRdLclVh020+J--