From owner-p4-projects@FreeBSD.ORG  Mon Mar  5 23:06:31 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A8F0B16A403; Mon,  5 Mar 2007 23:06:31 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4483616A400;
	Mon,  5 Mar 2007 23:06:31 +0000 (UTC)
	(envelope-from piso@newluxor.wired.org)
Received: from mail.oltrelinux.com (krisma.oltrelinux.com [194.242.226.43])
	by mx1.freebsd.org (Postfix) with ESMTP id 0423113C478;
	Mon,  5 Mar 2007 23:06:30 +0000 (UTC)
	(envelope-from piso@newluxor.wired.org)
Received: from newluxor.wired.org (ip-115-132.sn1.eutelia.it [62.94.115.132])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.oltrelinux.com (Postfix) with ESMTP id E8B1211AE49;
	Tue,  6 Mar 2007 00:06:28 +0100 (CET)
Received: (from piso@localhost)
	by newluxor.wired.org (8.13.8/8.13.8/Submit) id l25N6Cxb002600;
	Tue, 6 Mar 2007 00:06:12 +0100 (CET) (envelope-from piso)
Date: Tue, 6 Mar 2007 00:06:05 +0100
From: Paolo Pisati <piso@freebsd.org>
To: Paolo Pisati <piso@freebsd.org>
Message-ID: <20070305230605.GA2510@tin.it>
References: <200703052301.l25N1SCK070403@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200703052301.l25N1SCK070403@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.2i
X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at krisma.oltrelinux.com
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 115381 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Mar 2007 23:06:32 -0000

On Mon, Mar 05, 2007 at 11:01:28PM +0000, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=115381
> 
> Change 115381 by piso@piso_newluxor on 2007/03/05 23:01:11
> 
> 	Restore the sos's intendation style.
> 
> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#7 edit
> .. //depot/projects/soc2006/intr_filter/dev/scc/scc_core.c#15 edit
> 
> Differences ...
> 
[snip] 
> ==== //depot/projects/soc2006/intr_filter/dev/scc/scc_core.c#15 (text) ====
> 
> @@ -535,8 +535,8 @@
>  	if (device_get_parent(child) != dev)
>  		return (EINVAL);
>  
> -	/* Interrupt handlers must be FAST or MPSAFE. */
> -	if ((filter == NULL) && !(flags & INTR_MPSAFE))
> +	/* Interrupt handlers must be FILTER or MPSAFE. */
> +	if ((ihand != NULL) && !(flags & INTR_MPSAFE))
>  		return (EINVAL);
>  
>  	sc = device_get_softc(dev);

This should be:

o properly check for FILTER or MPSAFE handler.

bye,
P.