From owner-cvs-src@FreeBSD.ORG Fri Jan 19 16:44:50 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E036816A405; Fri, 19 Jan 2007 16:44:50 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.freebsd.org (Postfix) with ESMTP id 63F1D13C45B; Fri, 19 Jan 2007 16:44:50 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id l0JGimgc050040 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 19 Jan 2007 19:44:48 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id l0JGim6c050039; Fri, 19 Jan 2007 19:44:48 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 19 Jan 2007 19:44:47 +0300 From: Gleb Smirnoff To: mjacob@FreeBSD.org Message-ID: <20070119164447.GU4485@FreeBSD.org> References: <200701181355.l0IDtMFu003540@repoman.freebsd.org> <20070118185616.GA67767@dragon.NUXI.org> <20070118115113.U2516@ns1.feral.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20070118115113.U2516@ns1.feral.com> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, David O'Brien Subject: Re: cvs commit: src/sys/netgraph ng_ppp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2007 16:44:51 -0000 On Thu, Jan 18, 2007 at 11:51:44AM -0800, mjacob@freebsd.org wrote: m> >/usr/src/sys/modules/netgraph/ppp/../../../netgraph/ng_ppp.c: In function m> >`ng_ppp_rcvdata': m> >/usr/src/sys/modules/netgraph/ppp/../../../netgraph/ng_ppp.c:1287: m> >warning: comparison is always true due to limited range of data type m> >*** Error code 1 m> > m> >I commented out the KASSERT in order to get the kernel buildable again. m> >Would you be able to take a look at the logic in the KASSERT? I'd rather m> >not guess what you'd like there and possibly get it wrong. m> >thanks, m> m> Fools rush in (me). I changed the logic. Thanks, Matt.. And sorry everyone. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE