Date: Wed, 26 Nov 2008 03:22:14 +0100 From: insomniac <insomniac@slackware.it> To: freebsd-current@freebsd.org Cc: kensmith@freebsd.org Subject: Patch for bin/54446 Message-ID: <20081126032214.03d8517a@slackware.it>
next in thread | raw e-mail | index | archive | help
--Sig_/vj8ya+7JIXdl4S4vVSkWtJL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi to everyone, I wrote a patch for the bin/54446 PR, fixing pkg_delete(1) that doesn't honour symlinks, and portupgrades leads to failing services. Actually, this patch fixes that for all the utilities as it acts directly in the lib. I tested the patch on a few x86 machines, ranging from 7.0 to -HEAD. Testing and further reviewing are welcome and encouraged. pkg_delete now seems to work fine; moreover I found other bugs, like memory leaks, missing checks of function return values, and wrong return values. The patch has already been reviewed by attilio@ , it applies to src/usr.sbin/pkg_install/lib/plist.c and is located at http://insomniac.slackware.it/plist.c.diff Best regards, --=20 Andrea Barberio a.barberio@oltrelinux.com - Linux&C. andrea.barberio@slackware.it - Slackware Linux Project Italia GPG key on http://insomniac.slackware.it/gpgkey.asc 2818 A961 D6D8 1A8C 6E84 6181 5FA6 03B2 E68A 0B7D SIP: 5327786, Phone: 06 916503784 --Sig_/vj8ya+7JIXdl4S4vVSkWtJL Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iQEcBAEBAgAGBQJJLLLbAAoJEF+mA7Lmigt9l80IAKDDDB0NCJFJRgpPkhS4IpWc DJQf+rT+A5al8hmx27z1kpF6ezic6HNDMJyD1bcYbzLog5Bk9vNC0dEIRiswIB82 3jB3vaUBDMt9fCfHgsl3hDUonuDy+Em57W1o6VnpogVMKOi6fZwEY+V7PXIGF66d CEmjpYJw7QfvwnknmCq/ClarY1m51+Nm3MAaloq+eKb8ieF9Z6yclZOb4ur+CJFr I1E9rF/Rx+zyGiGVrSasLeHS6001YqgXOOiMsjCqK/vNOF4ENl/qZB+OGZ2vyMki 8rDvC9z4b1RHswJ+mtXuZiivKhGVdD+h8E40R4Q5gjJciCFa8ISSRjFNfEWxCqQ= =ygTD -----END PGP SIGNATURE----- --Sig_/vj8ya+7JIXdl4S4vVSkWtJL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081126032214.03d8517a>