From owner-cvs-all Mon Dec 3 1:41:12 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 690F437B417; Mon, 3 Dec 2001 01:41:01 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fB39eWS70723; Mon, 3 Dec 2001 11:40:32 +0200 (EET) (envelope-from ru) Date: Mon, 3 Dec 2001 11:40:32 +0200 From: Ruslan Ermilov To: Garrett Wollman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_mroute.c ip_output.c Message-ID: <20011203114032.C60143@sunbay.com> References: <200112011348.fB1DmGf07402@freefall.freebsd.org> <200112012051.fB1KpAp47152@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112012051.fB1KpAp47152@khavrinen.lcs.mit.edu> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Dec 01, 2001 at 03:51:10PM -0500, Garrett Wollman wrote: > < said: > > > Allow for ip_output() to be called with a NULL route pointer. > > This fixes a panic I introduced yesterday in ip_icmp.c,v 1.64. > > I think this fix is a bug. I want to require all callers of > ip_output() to already have either a route or an interface (iff > routing is disabled). > Actually, I just followed the BSD/OS, NetBSD and OpenBSD here, which all accept ro == NULL meaning ip_output() looks the route up itself. I don't see anything wrong here, and it also reduces the code bloat. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message