From owner-freebsd-hackers@FreeBSD.ORG Mon Apr 14 06:19:42 2014 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9EED85FB for ; Mon, 14 Apr 2014 06:19:42 +0000 (UTC) Received: from mail-wg0-x22d.google.com (mail-wg0-x22d.google.com [IPv6:2a00:1450:400c:c00::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2D7731659 for ; Mon, 14 Apr 2014 06:19:42 +0000 (UTC) Received: by mail-wg0-f45.google.com with SMTP id l18so7598301wgh.28 for ; Sun, 13 Apr 2014 23:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=n4C7YhbMTp3grfVgHKiWe14hLuxTNl3d7Ru7rhAXJxQ=; b=Rp1wR424eSvioBKmXFoE84NaiRCf4MGL5qT3jbuU9S72Uahw9nKkV+AeLyLMW9yWU1 2DFVhjUkI3AH1v2ymbJ7UFUO6ydoQei68WseVj/wy9fYaJH1PV8k39dzQWF0fb+rS+pm FZ/L1Hi5j2srbHjCjNsmZJmeT5kMHnOAz6YFwM4GxqgacxHd9sTCeFlKugzha5GCFdyS 3qVIDFAxqtDO7REx0HMD1zEyJia0TcEkO42ibG4TsDopOlS83eFaXsuJ87qAKzFzmViZ gp9WZkpfpWn1ul2ds8Jft60pp3xFdbEheJxxJQ8daZYyRYjoqaSDzz8o8lrFerGhRDTG C/6g== X-Received: by 10.180.89.102 with SMTP id bn6mr8217130wib.28.1397456380370; Sun, 13 Apr 2014 23:19:40 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id dr2sm21197431wid.2.2014.04.13.23.19.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Apr 2014 23:19:39 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 14 Apr 2014 08:19:37 +0200 From: Baptiste Daroussin To: Konstantin Belousov Subject: Re: [CFR] Kevent timer improvements Message-ID: <20140414061936.GA60058@ivaldir.etoilebsd.net> References: <20140310131632.GI6900@ithaqua.etoilebsd.net> <20140310180404.GI32089@funkthat.com> <20140413131550.GD17898@ivaldir.etoilebsd.net> <20140413142028.GD4016@kib.kiev.ua> <20140413191928.GE17898@ivaldir.etoilebsd.net> <20140413202038.GE4016@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: <20140413202038.GE4016@kib.kiev.ua> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: desrt@desrt.ca, John-Mark Gurney , "freebsd-hackers@freebsd.org" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Apr 2014 06:19:42 -0000 --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 13, 2014 at 11:20:38PM +0300, Konstantin Belousov wrote: > On Sun, Apr 13, 2014 at 09:19:28PM +0200, Baptiste Daroussin wrote: > > On Sun, Apr 13, 2014 at 05:20:28PM +0300, Konstantin Belousov wrote: > > > On Sun, Apr 13, 2014 at 03:15:51PM +0200, Baptiste Daroussin wrote: > > > > I have splitted my patch in multiple parts, let start with the firs= t one: > > > > adding NOTE_NSECONDS, NOTE_USECONDS, NOTE_NSECONDS > > > >=20 > > > > http://people.freebsd.org/~bapt/kevent_timer.diff > > >=20 > > [...] > > > > + else if (flags & NOTE_NSECONDS) > > > > + modifier =3D SBT_1NS; > > > It is better to put the 'modifier =3D SBT_1MS;' statement as the else= part. > > >=20 > > > That said, IMO it would be sometimes beneficial to have real flag to > > > specify milliseconds precision, in addition to milliseconds be the > > > default. > >=20 > > Done in the new patch > > > > + > > > > + timer2sbintime(kn->kn_sdata, kn->kn_sfflags), 0 /* 1ms? */, > > > There, at least the comment about precision should be updated. > > > But, it seems that for the seconds precision, it makes sense to > > > specify e.g. 1/2 sec as precision; or add an API flag to allow imprec= ise > > > callout scheduling. > > >=20 > > While I do agree this might be useful I do not have time to work on tha= t right > > now so I just removed the comment which wasn't really accurate anyway. > >=20 > > Is that ok? > Leave XXX comment right near the zero argument, at least ? >=20 > > + if (flags & NOTE_SECONDS) > > + modifier =3D SBT_1S; > > + else if (flags & NOTE_USECONDS) > > + modifier =3D SBT_1US; > > + else if (flags & NOTE_NSECONDS) > > + modifier =3D SBT_1NS; > > + else > > + modifier =3D SBT_1MS; > There should be a case for NOTE_MSECONDS. >=20 ok I'll do > Hm, I think the checks should be made stronger. System should ensure > that only one flag is passed, and no invalid flags are supplied, right ? I can check that only one flags is passed and no invalid flagrs are supplie= d but =66rom what I see not a single part of kqueue(2) is checking that, so won't= that be inconsistent with the rest of the API? I can probably check that only ona or 0 of the NOTE_*SECONDS is passed and return EINVAL in that case but no more. (note that more NOTE_* are to be added later) regards, Bapt --envbJBWh7q8WU6mo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlNLffgACgkQ8kTtMUmk6EwNiACgqi+lKt0PnyXazuSUpeaQesQv ogkAoKXz9fxAcVLrj2kta1533Cj56m3F =K9tE -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--