From owner-cvs-ports@FreeBSD.ORG Mon Aug 22 21:08:25 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41821106566B; Mon, 22 Aug 2011 21:08:25 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f172.google.com (mail-iy0-f172.google.com [209.85.210.172]) by mx1.freebsd.org (Postfix) with ESMTP id A84FF8FC19; Mon, 22 Aug 2011 21:08:24 +0000 (UTC) Received: by iye7 with SMTP id 7so21451786iye.17 for ; Mon, 22 Aug 2011 14:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=gVoeM59QI8PvuVGr1EG19g9PhdMDeROoZsKPfzqQ11w=; b=B1/uj9z1rRR+jCAtGAZ6cJZLJAHccU2R5ozTd2/+Bgb/9gdmzuHGKpPgU9IUfEsGGI pk2wEFfsFhZYaeNdpCBkUO7F/oWazQAPMPiDbTRkgJaerzNKkQwysl0vHC0WSUduiTEn 2cOknILEMmIoooXPqVUyaqvpUP7awwIG8RQw8= MIME-Version: 1.0 Received: by 10.231.56.75 with SMTP id x11mr6173991ibg.98.1314047304245; Mon, 22 Aug 2011 14:08:24 -0700 (PDT) Sender: utisoft@gmail.com Received: by 10.231.182.77 with HTTP; Mon, 22 Aug 2011 14:08:24 -0700 (PDT) Received: by 10.231.182.77 with HTTP; Mon, 22 Aug 2011 14:08:24 -0700 (PDT) In-Reply-To: <4E52C169.2080305@FreeBSD.org> References: <201108211100.p7LB0cB7060742@repoman.freebsd.org> <20110821114454.GA77777@FreeBSD.org> <20110821115214.GA85711@FreeBSD.org> <20110821120013.GA86358@FreeBSD.org> <4E52C169.2080305@FreeBSD.org> Date: Mon, 22 Aug 2011 22:08:24 +0100 X-Google-Sender-Auth: I-A-3m7zVC2LgwDlLNkSbEQXlCM Message-ID: From: Chris Rees To: "Joseph S. Atkinson" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Alexey Dokuchaev , cvs-all@freebsd.org, ports-committers@freebsd.org, Joe Marcus Clarke , Rene Ladan , cvs-ports@freebsd.org Subject: Re: cvs commit: ports/www/chromium Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2011 21:08:25 -0000 On 22 Aug 2011 21:51, "Joseph S. Atkinson" wrote: > > On 08/21/2011 09:13, Chris Rees wrote: >> >> >> On 21 Aug 2011 13:00, "Alexey Dokuchaev" > > wrote: >> > >> > On Sun, Aug 21, 2011 at 11:52:14AM +0000, Alexey Dokuchaev wrote: >> > > On Sun, Aug 21, 2011 at 12:48:38PM +0100, Chris Rees wrote: >> > > > I'd agree on FILESDIR. >> > > > >> > > > Anyone have a problem with adding a section on >> > > > wiki/PortsLongtermTargets about ports that use PATCHDIR? This >> > > > inconsistency is a little strange. >> > > >> > > Oh, please do. This inconsistency is not just strange, but rather annoying. >> > >> > As for the strange part, it seems like historical left-over from times when >> > ports had "patches" directory (I vaguelly recall the OpenBSD still does it >> > these days). Since FreeBSD had standardized on "files" long time ago, bpm >> > should stop using PATCHDIR and replace it with FILESDIR). Ditto for the >> > ports, of course. >> > >> >> PR filed at http://www.freebsd.org/cgi/query-pr.cgi?pr=159970 thanks for the >> motivation ;) >> >> Chris >> > > I will ping marcus and have him add a bit to portlint(1) and maybe check for hardcoding of files/ as well. > Make a patch you lazy git :P Chris