From owner-svn-src-all@freebsd.org Sat Mar 10 22:56:14 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7DD3F3C149; Sat, 10 Mar 2018 22:56:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B87687E29; Sat, 10 Mar 2018 22:56:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it0-x241.google.com with SMTP id v194-v6so7088413itb.0; Sat, 10 Mar 2018 14:56:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DyV32CBfUdom7Wkx0k660Nd98+QzjQ2x27k5XdQAyhw=; b=IKyYcRNVz9WQAUZ3gzRYXF4dPYN9T868tKZ/oBXhW/IYLxCK+KmgbIlIX0+RNOjD/y SqsmivtLxDGzX+wDlCEz/CHHTkfJ7Q2pMxuKXG01f/+OWW8o96FkScSpof7jBLNGWaoA oXmHAfYuXsjHsjknoocquwmq1pjsJiS+GO8qUmLPCO0cXNV2GPQZ2+u12kfil9HjFyE+ p9F99tYQanFYhP0UEFmssEoZ1kszXi/ChcNDEY1J2A+mKiSJMCRdXlDKWpru+T7z0t6X Y9dYXX3b7XPARPdCDsPIc1lTEd+d4/6Bcr9vVeDg2Yd4SQliYL/f+fZKpCTXvdYm8oJN Jwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=DyV32CBfUdom7Wkx0k660Nd98+QzjQ2x27k5XdQAyhw=; b=aBotvB7JMBeqbaDTkOdLuUcJEhIigTDUsu4fFkon+csxDdQkkK7Afge2wClHKiu0TW TzLfN6ZtUp35xlr+HNJj7kPsLmRq64IsqQn2HWyYP/hy4iA9+v6SHmDDLE265HomqSMo Mu9qAxLSYKBPy354cCrcjxLPOqU18Xy06iICXEts/JYx2o7jegFezci2hQDN5dPiLaNp oIqG0Qz58Z4daZnqv9fC9ZC3oI9+KZ72T2AcUNHp5DpakuxrXDHoWUsIIK+U9rOo9C/R 4+wwO2sDqmQK8sLhhMSbKLt1SmtPFmdxO7kkIkNCX41CWZUS+QnCa6Z4DYDfrMsoT3W4 CccA== X-Gm-Message-State: AElRT7Fm/wXMgATrI/qHcS3vU1SCXx/K/nY2j4gaGQry4WoS6f1Q5rBf 6uaK+3KHTFl22jZnJgWJgHuMUg== X-Google-Smtp-Source: AG47ELtVEKkCq5YocmSn9wm+GyUbxLcDmHH9j6o4M1mw60WWKjmX4m9XtV+K2HidMKLWKlqVl+cKJQ== X-Received: by 10.36.189.129 with SMTP id x123mr3422359ite.13.1520722573329; Sat, 10 Mar 2018 14:56:13 -0800 (PST) Received: from raichu (toroon0560w-lp130-01-174-88-76-226.dsl.bell.ca. [174.88.76.226]) by smtp.gmail.com with ESMTPSA id j19sm2759836ioe.15.2018.03.10.14.56.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Mar 2018 14:56:12 -0800 (PST) Sender: Mark Johnston Date: Sat, 10 Mar 2018 17:56:10 -0500 From: Mark Johnston To: David Bright Cc: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328013 - head/sbin/fsck_ffs Message-ID: <20180310225610.GD73335@raichu> References: <201801151925.w0FJPCKA019434@repo.freebsd.org> <20180309220940.GG6174@raichu> <1520634689.84937.74.camel@freebsd.org> <20180310161701.GA73335@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2018 22:56:15 -0000 On Sat, Mar 10, 2018 at 05:01:40PM -0500, David Bright wrote: > With regard to the fsck_ffs behavior being a regression because formerly the FS would be mounted successfully: > > That was not my experience. What I observed was that the “fsck -y” would give the “please re-run” message, exit with 0 status so the boot would continue, the subsequent mount would fail because the filesystem was not clean, and *then* the boot would stop and drop to single user. I think my problem is specific to SU without journaling. The UFS code allows one to mount an unclean filesystem in that configuration since SU guarantees that on-disk metadata is consistent. A background fsck takes care of leaked inodes and data blocks. (FWIW, I'm not using journaling only because makefs(8) doesn't support the creation of SU+J filesystems.) /dev/gpt/rootfs: FREE BLK COUNT(S) WRONG IN SUPERBLK (SALVAGED) /dev/gpt/rootfs: SUMMARY INFORMATION BAD (SALVAGED) /dev/gpt/rootfs: BLK(S) MISSING IN BIT MAPS (SALVAGED) /dev/gpt/rootfs: 32664 files, 495447 used, 813272 free (176 frags, 203274 blocks, 0.0% fragmentation) ***** PLEASE RERUN FSCK ***** WARNING: /: reload pending error: blocks 192 files 3 Unknown error 16; help! ERROR: ABORTING BOOT (sending SIGTERM to parent)! Mar 10 12:47:50 init: /bin/sh on /etc/rc terminated abnormally, going to single user mode Enter full pathname of shell or RETURN for /bin/sh: # mount /dev/gpt/rootfs on / (ufs, local, read-only) devfs on /dev (devfs, local, multilabel) # mount -u -o rw / WARNING: / was not properly dismounted # echo $? 0 # mount /dev/gpt/rootfs on / (ufs, local, soft-updates) devfs on /dev (devfs, local, multilabel)