From owner-freebsd-scsi Mon Sep 30 04:09:10 1996 Return-Path: owner-freebsd-scsi Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id DAA16446 for freebsd-scsi-outgoing; Mon, 30 Sep 1996 03:47:38 -0700 (PDT) Received: from who.cdrom.com (who.cdrom.com [204.216.27.3]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id DAA16242 for ; Mon, 30 Sep 1996 03:47:24 -0700 (PDT) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by who.cdrom.com (8.7.5/8.6.11) with SMTP id XAA19377 for ; Sun, 29 Sep 1996 23:56:00 -0700 (PDT) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id IAA02274; Mon, 30 Sep 1996 08:51:08 +0200 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id IAA14679; Mon, 30 Sep 1996 08:51:07 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.7.5/8.6.9) id IAA11367; Mon, 30 Sep 1996 08:25:42 +0200 (MET DST) From: J Wunsch Message-Id: <199609300625.IAA11367@uriah.heep.sax.de> Subject: Re: HP T4000s tape drive To: freebsd-scsi@FreeBSD.ORG Date: Mon, 30 Sep 1996 08:25:42 +0200 (MET DST) Cc: richard@cogsci.ed.ac.uk Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <1348.199609292250@pitcairn.cogsci.ed.ac.uk> from Richard Tobin at "Sep 29, 96 11:50:56 pm" X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E X-Mailer: ELM [version 2.4ME+ PL17 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-scsi@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Richard Tobin wrote: > > > + #define QIC_3095 0x45 > > What do you need this for? > > I don't use it, but the other tape types have #defines, and there are Not quite all of them. :) > a couple of switch statements that switch on tape type and I'm not > sure whether they should include this one. In particular, there's one I think this switch statement is half-bogus, too. If i remember well, it tries to figure out whether a particular tape might be fixed or variable record-length. Only a few (old) drives don't grok variable, so the switch statement certainly doesn't need to be extended. > > > ! #define SCSI_2_MAX_DENSITY_CODE 0xff /* SCSI 2 spec is out of date! */ > > and this? The entire check for a ``max density'' could go. > > Well the user passes it in as a u_int32 (in the ioctl) and it gets > assigned to a u_char (for the scsi_select), so perhaps a range check > is still appropriate? No. It's garbage. There's no use of limiting the density range that could be passed down to the device. The worst that happens (if a user specifies a bogus density in the ``mt density'' command) is a SCSI error that will pop up on the console. We already agreed before that this test can go away. > > Justin, would commiting this conflict with your branch? (Ok, i can > > also check myself.) > > Remember it was a patch relative to 2.1.0-RELEASE! Yep. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)