Date: Mon, 30 Sep 1996 08:25:42 +0200 (MET DST) From: J Wunsch <j@uriah.heep.sax.de> To: freebsd-scsi@FreeBSD.ORG Cc: richard@cogsci.ed.ac.uk Subject: Re: HP T4000s tape drive Message-ID: <199609300625.IAA11367@uriah.heep.sax.de> In-Reply-To: <1348.199609292250@pitcairn.cogsci.ed.ac.uk> from Richard Tobin at "Sep 29, 96 11:50:56 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
As Richard Tobin wrote: > > > + #define QIC_3095 0x45 > > What do you need this for? > > I don't use it, but the other tape types have #defines, and there are Not quite all of them. :) > a couple of switch statements that switch on tape type and I'm not > sure whether they should include this one. In particular, there's one I think this switch statement is half-bogus, too. If i remember well, it tries to figure out whether a particular tape might be fixed or variable record-length. Only a few (old) drives don't grok variable, so the switch statement certainly doesn't need to be extended. > > > ! #define SCSI_2_MAX_DENSITY_CODE 0xff /* SCSI 2 spec is out of date! */ > > and this? The entire check for a ``max density'' could go. > > Well the user passes it in as a u_int32 (in the ioctl) and it gets > assigned to a u_char (for the scsi_select), so perhaps a range check > is still appropriate? No. It's garbage. There's no use of limiting the density range that could be passed down to the device. The worst that happens (if a user specifies a bogus density in the ``mt density'' command) is a SCSI error that will pop up on the console. We already agreed before that this test can go away. > > Justin, would commiting this conflict with your branch? (Ok, i can > > also check myself.) > > Remember it was a patch relative to 2.1.0-RELEASE! Yep. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199609300625.IAA11367>