From owner-freebsd-hackers Mon Jan 12 17:28:32 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.7/8.8.7) id RAA03666 for hackers-outgoing; Mon, 12 Jan 1998 17:28:32 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id RAA03500 for ; Mon, 12 Jan 1998 17:27:40 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id BAA04877; Tue, 13 Jan 1998 01:27:23 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.6/8.8.6) id CAA19638; Tue, 13 Jan 1998 02:27:22 +0100 (MET) Message-ID: <19980113022721.32158@follo.net> Date: Tue, 13 Jan 1998 02:27:21 +0100 From: Eivind Eklund To: dennis Cc: Eivind Eklund , Tom , Jamie Bowden , hackers@FreeBSD.ORG Subject: Re: FreeBSD Netcards References: <3.0.32.19980112201715.00a43cb0@etinc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.88e In-Reply-To: <3.0.32.19980112201715.00a43cb0@etinc.com>; from dennis on Mon, Jan 12, 1998 at 08:17:15PM -0500 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk On Mon, Jan 12, 1998 at 08:17:15PM -0500, dennis wrote: > At 10:38 PM 1/12/98 +0100, Eivind Eklund wrote: >> dennis writes: >>> Just look in raw_usrreq(). the default case is a panic. >> >> Fixed in revision 1.12 as of April 27, 1997. >> >> Do you have anything else? (I don't think any of us want panic()s to >> occur for userland errors, though I think they often are the correct >> path for a kernel error.) > > 2.2.5-RELEASE is shipped with v1.8 which is dated 3/11/96, so > something is amiss. If it takes a year for these fixes to make it > into a release it doesnt do anyone any good... Well, this was fixed as a part of a major rewrite of that part of the code. The patch that fixes this is actually twice as large as the raw_usrreq file. I also _think_ it links in with more modifications elsewhere, but I haven't looked to closely - it came in in a mega-commit, at least. At least be happy it is fixed in 3.0 :-) Do you have any other cases of panic() being used incorrectly? Eivind.