From owner-freebsd-ports@freebsd.org Tue Apr 18 14:24:23 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F51AD443FE for ; Tue, 18 Apr 2017 14:24:23 +0000 (UTC) (envelope-from jlaffaye.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0DAE332D for ; Tue, 18 Apr 2017 14:24:23 +0000 (UTC) (envelope-from jlaffaye.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 0D1A1D443FD; Tue, 18 Apr 2017 14:24:23 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0CC2DD443FC for ; Tue, 18 Apr 2017 14:24:23 +0000 (UTC) (envelope-from jlaffaye.freebsd@gmail.com) Received: from mail-yw0-x232.google.com (mail-yw0-x232.google.com [IPv6:2607:f8b0:4002:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BFA4632B for ; Tue, 18 Apr 2017 14:24:22 +0000 (UTC) (envelope-from jlaffaye.freebsd@gmail.com) Received: by mail-yw0-x232.google.com with SMTP id l189so70258369ywb.0 for ; Tue, 18 Apr 2017 07:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=abgL2vrZa8BnDvJQobabOpWK4t2pr3mnnFRhxpbgk6Y=; b=FxLDXkAMGNZ0X/j94SdLZtJqT0PfFiu8tL16ROHjZy4VzAjUgddYSpMIZ6SZLrEDph lrvqgtrXyJpf0TMnjobEhABNF5v4CRrFv3EfMuoyXaJzejMi2XU3VVprCXdgcCIz9QMa +qK/IIK3bVV66slghut2eUxcUBudN97NzGPx+vvEDPDqTbAncS3MbiF4kkU3mVxlCeXz 3D7voLBoRaiCmg60QrOMF/cbLf7rwApFbkd/AJGU7ouvFKbX73xQfhTMND09ss6UcLCT MEOMxdy0EtkxJDDIQHWuwa8FD6TwcAPhVROMeOUxa5Ywx7/cUVbRBKHgnt4jtA7LaPGh KfeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=abgL2vrZa8BnDvJQobabOpWK4t2pr3mnnFRhxpbgk6Y=; b=PpICoNS48utCVzMo67TH5eG0030pahwtrfR/ZUrcW8P8jyX6ISG8TFumfI6nYHjzwa maOCzhIqDp8RpofDuL6KoS5olU4vtRD0PS/u13ysRJGXEs5PPU/+X6XTtv9P2eoFBazB M/QFxGH8CEub5fUfFLFgnyGwMeWBnn1ZgUbeWQqFOPXf4pKKJc+QwsmQY8wqPIXRmErP li+a1xTkp7UQOFe6z+S1dPzbVjmxeXDCV5aBcjzy0i3mH/MSbi1yZSyyRNust7T5M0SD 74gmBvwnd9vd5E+UJrE2PEseAKzV9ugymNcvhePuCPsQivYHvvlRFZeUOpogkl68K3y3 UQIg== X-Gm-Message-State: AN3rC/4E/FdbKhQEJT60ICd09j9TIE9FQxjZmHxctQ9IDr4tpqBQove+ xbkF90f6/nDakjEYO2sqYyDxhx65qynb X-Received: by 10.36.1.20 with SMTP id 20mr8257395itk.102.1492525461892; Tue, 18 Apr 2017 07:24:21 -0700 (PDT) MIME-Version: 1.0 Sender: jlaffaye.freebsd@gmail.com Received: by 10.79.157.140 with HTTP; Tue, 18 Apr 2017 07:24:21 -0700 (PDT) In-Reply-To: References: From: Julien Laffaye Date: Tue, 18 Apr 2017 16:24:21 +0200 X-Google-Sender-Auth: cgMcCrGzONnSOi532BuRzkc6Uh4 Message-ID: Subject: Re: Packaging Go Libs To: Steve Wills Cc: "ports@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 14:24:23 -0000 I agree with you. Maybe we should provide helpers to do the "fetching dependencies" part so that will be less cumbersome. On Mon, Apr 17, 2017 at 4:20 PM, Steve Wills wrote: > Hi, > > I'd like to propose eliminating packaging of Go libs. > > Almost every Go app is developed with a different version of any given > lib than what another Go app might use. Forcing a Go app to use a > different version than what upstream might have chosen is error prone at > best and likely to produce a build that's unsupported upstream. So for > the packaged libs to even be useful, we would have to have as many > versions of each lib as there are consumers, or nearly as many. > > Further, best practice in the Go community is for Go apps to vendor all > their dependencies and almost all apps do that. This is the reason most > Go apps use different versions of it's libs. > > So to me, packaging Go libs doesn't make sense and I think we should > remove the Go libs from ports. > > Existing ports which use the Go libs should be updated to not use the Go > lib ports by doing one of these, in priority order: > > * Converted to using vendored deps included with the package source if > possible (preferred) > * Fetching the versions of deps specified by upstream (in the case of > vendor.json) > * As a last resort (deps are not included nor versions specified > exactly) fetching versions of deps available at the time of upstream > development > > Further, documentation should be added to the Porters Handbook saying > that we don't package Go libs and portlint should be updated to check > for installing files in GO_SRCDIR and GO_LIBDIR (exceot lang/go*). > > For reference, here's the list of Go lib ports that I found at the moment: > > archivers/go-compress > databases/gomdb > databases/gosqlite3 > databases/levigo > databases/radix.v2 > databases/redigo > devel/go-bayesian > devel/go-cobra > devel/go-codec > devel/go-cpuid > devel/go-crc32 > devel/go-faker > devel/go-form > devel/go-go.uuid > devel/go-goregen > devel/go-hashicorp-logutils > devel/go-json-rest > devel/go-logrus > devel/go-metrics > devel/go-nuid > devel/go-pflag > devel/go-protobuf > devel/go-raw > devel/go-runewidth > devel/go-slices > devel/go-sql-driver > devel/go-uuid > devel/go-yaml > devel/goprotobuf > net/go-amqp > net/go-geoip > net/go-httppath > net/go-httptreemux > net/go-nats > net/go.net > security/go.crypto > security/goptlib > textproc/go.text > www/go-fasthttp > www/webgo > > Does anyone have any objection or reasoning why this doesn't make sense? > > Thanks, > Steve > >