From owner-svn-ports-all@freebsd.org Fri Nov 6 16:01:16 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 59331442414; Fri, 6 Nov 2020 16:01:16 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CSQ9S1CqPz4RLZ; Fri, 6 Nov 2020 16:01:15 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-qv1-xf29.google.com with SMTP id 63so650124qva.7; Fri, 06 Nov 2020 08:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qx9Bgbd6Scrhx9hZykoO+yL2LBn0sTUx1Bond18EUdY=; b=nr41q10l9ubHDNMRJPhOzgDv/iX/cIoQ15hu1MA+ywepq/94GxPrSwPjMEEmiGiIUQ +8Et0If6kaqAB5OLl8fL6s5K+fI3ML6jL6NOm/3Re/lQakkNNQlns6frqdTkFINHDLAq fr75MK+wNykuMHrxOZLuueLW5ops9b5EFotIE35wEYntzP36qwJcOs5vcwwRHunzxCpS f1urgjw8TmWRMZDr1Ij49/3KSg71qPZljqLUvYpHCEhLDsjF4Fvie4QxwGcAKEhbb051 wFn4sBAprZj4uRCoxY/QoBniEhPS2lq0PmEGSgXBWuEyIxHtWHRyZXFAsuJTbTAXZzRU hi4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qx9Bgbd6Scrhx9hZykoO+yL2LBn0sTUx1Bond18EUdY=; b=YAHGBJBu4RWRlx/LSR2HwfJi7CbsBkqe+BvZoMxD9wljn3k5Zfe20CmGJYXx+6wZBp 63h9GfxQkA1KzkbKmnwlYIJ/HjBH4HmGdxQmGgA8/U5Eu5xjlKRq+e56ZbFFSPY/AbRv +rsqapFhPiZFzlz0yxJMVVGPZcFEDqtGiDHUQ+B9DlXP9kfLdAz1qGh2HKSjB7pELEUD 4ZjE30pujO1Ayfvu+8wZP51Wzl0tu6/uxU81wLgH9hjHWS3UEcEtOQGc1xNLwI4ZY5X/ 9bQGJcbFM7lrAE3VWK6pUean23w+3Xo8NqKLhwOKw5ZMOEnx2IrnczqoBqV9+iyvi6yc GcVg== X-Gm-Message-State: AOAM532T7aOJcYrfGSsP/7t6MmwrurpCMpeIkqHz0mKYNeLuDt34WGU+ cqGtOx228+IC20emeCm7O+wO8FGL+ws= X-Google-Smtp-Source: ABdhPJzHkc9tV4SN2tpMEE3+0PK95ZCmsdT0GI4YkhzujkcIogErL08zl/ri4mE3qrpCeoRXqeteJQ== X-Received: by 2002:ad4:45f1:: with SMTP id q17mr711046qvu.52.1604678474321; Fri, 06 Nov 2020 08:01:14 -0800 (PST) Received: from mbp.home ([2804:f1c:7300:cb00:6c16:78c2:5bfb:11a8]) by smtp.gmail.com with ESMTPSA id j5sm737607qtv.91.2020.11.06.08.01.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2020 08:01:13 -0800 (PST) Sender: Renato Botelho Subject: Re: svn commit: r554143 - head/devel/git To: Guido Falsi , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202011051704.0A5H4Jf8010250@repo.freebsd.org> <1ef8c98e-49e4-3aff-2886-4991d264ab2f@FreeBSD.org> <24edb45e-1e5a-fe05-30ef-36022e041dc1@FreeBSD.org> From: Renato Botelho Message-ID: <29a040dc-99d4-535e-2be4-14a80a4dd266@FreeBSD.org> Date: Fri, 6 Nov 2020 13:01:10 -0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <24edb45e-1e5a-fe05-30ef-36022e041dc1@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4CSQ9S1CqPz4RLZ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 16:01:16 -0000 On 06/11/20 11:36, Guido Falsi wrote: > On 06/11/20 12:41, Renato Botelho wrote: >> On 06/11/20 04:22, Guido Falsi wrote: >>> On 05/11/20 18:04, Renato Botelho wrote: >>>> @@ -76,6 +73,8 @@ OPTIONS_EXCLUDE=    GUI SVN GITWEB CONTRIB P4 CVS >>>> PERL >>>>   .endif >>>>   OPTIONS_SUB=    yes >>>> + >>>> +OPTIONS_FILE=        ${PORT_DBDIR}/${OPTIONS_NAME}/${FLAVOR}-options >>> >>> I'm not sure why, but this is not working as expected IMHO. >>> >>> I noticed that, when using "poudriere options" and building with >>> "poudriere bulk" the options file is ignored. poudsriere option >>> continuously brings up the git dialog4ports screen and asks options >>> proposing the defaults. The option file is correctly written but >>> never read. poudriere bulk ignores it and builds with default options. >> >> I never used `poudriere options` before and indeed it seems to have a >> bug there.  For some reason I didn't understand yet poudriere >> considers git (with default flavor) as a dependency of git (with lite >> or gui flavor) and it's not correct. >> >> I tested a build with `poudriere testport -c -j JAIL devel/git@lite` >> and changed some options.  It worked as expected as you can see at [1]. >> >>> Also on the local machine running make config repeatedly in the port >>> directory does the same: the dialog4ports sscreen comes up with >>> default options each time and the options file is written but never >>> read. >> >> I made lots of tests here and everything worked.  The way I did it was >> using: >> >> # make FLAVOR=(lite|gui) [config|showconfig|rmconfig] >> >> and I couldn't reproduce any issue.  Every time selected options were >> respected by showconfig, which reads file saved on config step. >> > > Ok, I Think I see the problem. > > Did you try doing "make config" without passing any flavor? > > Ports framework does not define a default flavor for you, so if you > don't specify one on the command line in some way, while it works most > of the time, with git port it can't work, because the FLAVOR variable is > undefined when it gets to expanding it in OPTIONS_FILE. > > If I run "make config" without a FLAVOR definition it misbehaves. > > I made a test adding a FLAVOR?= ${FLAVORS:[1]} line just below FLAVORS > definition, and it now behaves correctly with "make config". It looks > like it still misbehaves with poudriere options though, which is > strange, I thought the FLAVOR trick would fix that too. I'm trying to > understand why. > Can you try this patch and see if it helps? https://bast.garga.net.br/files/git_options.diff -- Renato Botelho