Date: Fri, 12 Oct 2018 22:10:57 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Sean Bruno <sbruno@freebsd.org> Cc: Tobias Kortkamp <tobik@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r481915 - in head/sysutils/ipmitool: . files Message-ID: <20181012201057.rhvyjebk5rjb5jcu@atuin.in.mat.cc> In-Reply-To: <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org> References: <201810121751.w9CHpbfM070987@repo.freebsd.org> <1539367083.328758.1540102872.2C88E8B9@webmail.messagingengine.com> <530dca2f-e668-3c5b-9c91-346ebda2366f@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--stgsyjkbyvyvkrhz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Oct 12, 2018 at 12:05:34PM -0600, Sean Bruno wrote:
>=20
>=20
>=20
>=20
> > =20
> >> +.include <bsd.port.options.mk>
> >> +
> >> +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1200085
> >> +EXTRA_PATCHES=3D ${PATCHDIR}/extra-patch-
> >> src_plugins_lanplus_lanplus__crypt__impl.c
> >> +.endif
> >> +
> >=20
> > When the port is built with DOCS=3Doff EXTRA_PATCHES has
> > already been set earlier. This is overwriting it. You must
> > use EXTRA_PATCHES+=3D here.
> >=20
> >=20
>=20
>=20
> Can you do me a favor and submit or commit an update to the porter's
> handbook for this? Its what I used to generate this diff.
So, you want us to add something like "if the variable EXTRA_PATCHES is
already set before, instead of using =3D, use +=3D"?
I don't really see it happening, we are not going to state all the
possible cases, the porter's handbook would end up being ISO9001 and 50k
pages long, we assume that you know make(1), so that when you add a
variable, you actually look for it in the Makefile to see if it is not
already set.
--=20
Mathieu Arnold
--stgsyjkbyvyvkrhz
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlvA/9FfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkiGLQ//UQH1Dnkx0M1vx5eK5YZ+SXu0u5XjTI+AWDdViAgeKUi5sw/BmxsahEqq
a+b4Q6sNBHMeK2JnYv9vlQr6IIjBWfv2YnO+giDoDNzTNAKw+Og/7saOypZ0C+YM
o0KsWqCt1fNVdZEWPEBRjRdNyvojGHYP+swPpznTADk0S9uyB4bIxpi6Ss90uEi3
dPqYqXsBM5gBUDy0d5pSrT5Qu58/8XmQfDS39uoSbfCB04Nf+ydez/jas4xnxckx
N63Q7MokDQyIT1OQoHwCOCDUw79Pk65ZOqq5/EqaHIE7Yp190knSUDrrgu4p8z5g
Pj+0k53enEUGfPjAgBoH77merIZS7mMEAa0OxBYeDHLQIVaVz4nv88yrC03sA8r7
EBCxXFKqRuLUIzMpbBYwN1OCnFnixAaJ3sYKwoCnvJM1ChGZ3PaYouuOaxA4nP6b
e6o2lyTsB6YK/JDCWl6pPJ0VhuLLz4LF0zVeJFPp7JT9e+Ah7fVXe+nG4hclusVP
AWIKMdp8rtYMxEj+NQXHVKdlqtpB4XPmlsMgy6PAnPbCxa63DcGUG/sQ/dT46heN
K6EqgyFBg7wx4xLd9l8gDyo35UJMQdWjheWweVtgChxhM7byQg46aqCihyiqnAZk
ALnMOMS4PhLdA0pggLanWFTmYwewhOxrBfuzp7BaDCRgyc9o+0o=
=ikhb
-----END PGP SIGNATURE-----
--stgsyjkbyvyvkrhz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181012201057.rhvyjebk5rjb5jcu>