From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 21 23:40:01 2010
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
by hub.freebsd.org (Postfix) with ESMTP id 170A4106564A
for <freebsd-ports-bugs@hub.freebsd.org>;
Mon, 21 Jun 2010 23:40:01 +0000 (UTC)
(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
[IPv6:2001:4f8:fff6::28])
by mx1.freebsd.org (Postfix) with ESMTP id E3E928FC0A
for <freebsd-ports-bugs@hub.freebsd.org>;
Mon, 21 Jun 2010 23:40:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o5LNe072046625
for <freebsd-ports-bugs@freefall.freebsd.org>;
Mon, 21 Jun 2010 23:40:00 GMT
(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o5LNe0wB046624;
Mon, 21 Jun 2010 23:40:00 GMT (envelope-from gnats)
Resent-Date: Mon, 21 Jun 2010 23:40:00 GMT
Resent-Message-Id: <201006212340.o5LNe0wB046624@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
Dmitry Marakasov <amdmi3@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
by hub.freebsd.org (Postfix) with ESMTP id 9B95E1065670
for <FreeBSD-gnats-submit@freebsd.org>;
Mon, 21 Jun 2010 23:30:21 +0000 (UTC)
(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15])
by mx1.freebsd.org (Postfix) with ESMTP id 57E388FC0C
for <FreeBSD-gnats-submit@freebsd.org>;
Mon, 21 Jun 2010 23:30:21 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
(Exim 4.71) (envelope-from <amdmi3@amdmi3.ru>) id 1OQqRX-0000mj-Kd
for FreeBSD-gnats-submit@freebsd.org; Tue, 22 Jun 2010 03:30:19 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
by hive.panopticon (Postfix) with ESMTP id F4049B855
for <FreeBSD-gnats-submit@freebsd.org>;
Tue, 22 Jun 2010 03:30:17 +0400 (MSD)
Received: by hades.panopticon (Postfix, from userid 1000)
id F04A8B829; Tue, 22 Jun 2010 03:30:17 +0400 (MSD)
Message-Id: <20100621233017.F04A8B829@hades.panopticon>
Date: Tue, 22 Jun 2010 03:30:17 +0400 (MSD)
From: Dmitry Marakasov <amdmi3@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Cc:
Subject: ports/148051: bsd.port.mk: include gnome.mk for INSTALLS_ICONS
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Dmitry Marakasov <amdmi3@FreeBSD.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jun 2010 23:40:01 -0000
>Number: 148051
>Category: ports
>Synopsis: bsd.port.mk: include gnome.mk for INSTALLS_ICONS
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Jun 21 23:40:00 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Marakasov
>Release: FreeBSD 8.0-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #2: Wed Jun 2 02:28:21 MSD 2010 root@hades.panopticon:/async/obj/usr/src/sys/HADES i386
>Description:
In order for INSTALLS_ICONS to work, gnome.mk should be included. This means that unless USE_GNOME is explicitely defined, one should define WANT_GNOME along with INSTALLS_ICONS, which is easy to forget and error prone, so fix bsd.port.mk to include bsd.gnome.mk if INSTALLS_ICONS is defined.
>How-To-Repeat:
>Fix:
--- bsd.port.mk.patch begins here ---
Index: bsd.port.mk
===================================================================
RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.642
diff -u -r1.642 bsd.port.mk
--- bsd.port.mk 4 Jun 2010 08:09:17 -0000 1.642
+++ bsd.port.mk 21 Jun 2010 23:26:43 -0000
@@ -1556,7 +1556,7 @@
.include "${PORTSDIR}/Mk/bsd.gecko.mk"
.endif
-.if defined(WANT_GNOME) || defined(USE_GNOME)
+.if defined(WANT_GNOME) || defined(USE_GNOME) || defined(INSTALLS_ICONS)
.include "${PORTSDIR}/Mk/bsd.gnome.mk"
.endif
--- bsd.port.mk.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted: