From owner-p4-projects@FreeBSD.ORG Mon Feb 18 16:37:38 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5836C16A468; Mon, 18 Feb 2008 16:37:38 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1ACB016A421; Mon, 18 Feb 2008 16:37:38 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from mail.semihalf.com (mail.semihalf.com [83.15.139.206]) by mx1.freebsd.org (Postfix) with ESMTP id 77BBF13C45D; Mon, 18 Feb 2008 16:37:37 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from localhost (unknown [127.0.0.1]) by mail.semihalf.com (Postfix) with ESMTP id 9876014387; Mon, 18 Feb 2008 17:45:57 +0100 (CET) Received: from mail.semihalf.com ([127.0.0.1]) by localhost (mail.semihalf.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 11972-02; Mon, 18 Feb 2008 17:45:56 +0100 (CET) Message-ID: <47B9B44D.9040604@semihalf.com> Date: Mon, 18 Feb 2008 17:37:33 +0100 From: Rafal Jaworowski MIME-Version: 1.0 To: Marcel Moolenaar References: <200802162141.m1GLfgkj048217@repoman.freebsd.org> <47B75EB3.2020001@semihalf.com> <504560A3-EABB-4896-8B3E-C7FC89F31EFB@mac.com> <47B84D9B.4010903@semihalf.com> <47B8A8CD.3040707@semihalf.com> <755B845B-F43E-463D-8D87-7596A8C462F8@mac.com> In-Reply-To: <755B845B-F43E-463D-8D87-7596A8C462F8@mac.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at semihalf.com Cc: Marcel Moolenaar , Perforce Change Reviews Subject: Re: PERFORCE change 135517 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2008 16:37:38 -0000 Marcel Moolenaar wrote: >> Another comment: please note that killing WITH_UBOOT introduces another >> problem: now both sys/boot/powerpc/uboot/loader and >> sys/boot/powerpc/ofw/loader are built during buildworld, which may be >> good >> from one point of view, but there's no control over which of the >> loader file >> is taken during installworld: it seems the last one (u-boot's in this >> case) >> overwrites the previous... > > Oh, yeah. We need to rename the U-Boot loader... > > More comments: with 1GB, the API signature is not found. What we > probably should do is have the platform-specific entry set a > hint, which can be based on the address of the global data. In > other words: on PowerPC in start.S, we save r2 and use that to > control where we're going to search for the API signature. > Ah, so the lowest 256MB constraint which I mentioned in this other email must have been removed. I like your hint discovery, very nice :-) Rafal