From owner-freebsd-current  Thu Mar 27 21:06:09 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id VAA19634
          for current-outgoing; Thu, 27 Mar 1997 21:06:09 -0800 (PST)
Received: from rf900.physics.usyd.edu.au (rf900.physics.usyd.edu.au [129.78.129.109])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id VAA19627
          for <current@freebsd.org>; Thu, 27 Mar 1997 21:06:02 -0800 (PST)
Received: (from dawes@localhost) by rf900.physics.usyd.edu.au (8.8.5/8.8.2) id QAA02336 for current@freebsd.org; Fri, 28 Mar 1997 16:05:44 +1100 (EST)
From: David Dawes <dawes@rf900.physics.usyd.edu.au>
Message-Id: <199703280505.QAA02336@rf900.physics.usyd.edu.au>
Subject: Re: dumpfs patch for review
In-Reply-To: <199703280002.LAA10496@godzilla.zeta.org.au> from Bruce Evans at "Mar 28, 97 11:02:10 am"
To: current@freebsd.org
Date: Fri, 28 Mar 1997 16:05:43 +1100 (EST)
X-Mailer: ELM [version 2.4ME+ PL30 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

>>> It's still ugly.
>>
>>It's better than nothing...
>
>It's worse than not printing the new fields.
>
>>> >+ 	    afs.fs_id[1], ctime((time_t *)&afs.fs_id[0]));
>>>                                 ^^^^^^^^^^
>>> 
>>> Bogus cast.  Just as wrong as the one in fsirand.c.
>>
>>Since fs_id[0] is declared as int_32, I have to cast it to time_t in
>>order for it to be 'right' (according to fsirand).

Sort of related: building dumpfs on RELENG_2_2 is broken because
it hasn't been updated for the ffs.h changes.  It still has references
to the old fields.

David