Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Mar 1997 16:05:43 +1100 (EST)
From:      David Dawes <dawes@rf900.physics.usyd.edu.au>
To:        current@freebsd.org
Subject:   Re: dumpfs patch for review
Message-ID:  <199703280505.QAA02336@rf900.physics.usyd.edu.au>
In-Reply-To: <199703280002.LAA10496@godzilla.zeta.org.au> from Bruce Evans at "Mar 28, 97 11:02:10 am"

next in thread | previous in thread | raw e-mail | index | archive | help
>>> It's still ugly.
>>
>>It's better than nothing...
>
>It's worse than not printing the new fields.
>
>>> >+ 	    afs.fs_id[1], ctime((time_t *)&afs.fs_id[0]));
>>>                                 ^^^^^^^^^^
>>> 
>>> Bogus cast.  Just as wrong as the one in fsirand.c.
>>
>>Since fs_id[0] is declared as int_32, I have to cast it to time_t in
>>order for it to be 'right' (according to fsirand).

Sort of related: building dumpfs on RELENG_2_2 is broken because
it hasn't been updated for the ffs.h changes.  It still has references
to the old fields.

David



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703280505.QAA02336>