From owner-dev-commits-src-main@freebsd.org Tue Jan 12 03:25:08 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 93E084EF528; Tue, 12 Jan 2021 03:25:08 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DFGD43fMCz3r1Q; Tue, 12 Jan 2021 03:25:08 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qt1-f169.google.com with SMTP id c1so785934qtc.1; Mon, 11 Jan 2021 19:25:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HkzH7CNvuHGjxQDDo+9AJa2trHozJOUXfaDWpK1TD9I=; b=mSJvqBFdd+E1dvU4JOcz2IlPS82iWO2G0OQ5Eei88vrDtsh472p655x1TGRyTFRGbs ei7MrCldcEDa+YF4cMVZKeQDUtS6OHLWT2p+MQj4df+yO16onE/Fr8yI3w/DXsbmQXip a52XXvbNXcowrUt0x0Ej4z/vmgy0NNmStTlZyy7XYI7wlX6re18HfQoa/aFgcsZZc9fP xec1pyDCZp2eIhfhxVeN8PN3B9lUhtFiftoJkqBlMaAQXmM6nQw87v6k0nMnEU5Ctsfp 2o5bZIWU1DuvkymATvQD8SUVvZcMbkuKwRPitNxZuSbRbF6A3KjegFx6FYFM/ThTsufj Ib7A== X-Gm-Message-State: AOAM532NiIsGaf4Hjfk+LisFyBNiUJWdMfik6CBNnKlyhc8Bp1/QMYB5 2sjsBBO3S17lPxxS86NshR8oTOD9tOFw4Q== X-Google-Smtp-Source: ABdhPJz76zjGiKMuPwLyLieByKvDRCKTdrVCeuGHPbCu8Iezvjwis1Fm82BNMe7SlN7jHd4y5W3nHw== X-Received: by 2002:ac8:6e90:: with SMTP id c16mr2670302qtv.391.1610421906931; Mon, 11 Jan 2021 19:25:06 -0800 (PST) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com. [209.85.222.180]) by smtp.gmail.com with ESMTPSA id p75sm814733qka.72.2021.01.11.19.25.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 19:25:06 -0800 (PST) Received: by mail-qk1-f180.google.com with SMTP id c7so811041qke.1; Mon, 11 Jan 2021 19:25:06 -0800 (PST) X-Received: by 2002:ae9:f312:: with SMTP id p18mr2433179qkg.311.1610421906371; Mon, 11 Jan 2021 19:25:06 -0800 (PST) MIME-Version: 1.0 References: <202101120210.10C2ADmg048698@gitrepo.freebsd.org> In-Reply-To: <202101120210.10C2ADmg048698@gitrepo.freebsd.org> From: Ryan Libby Date: Mon, 11 Jan 2021 19:24:55 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 292808246db7 - main - ICMP checksum test: Fix for big endian To: Alan Somers Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DFGD43fMCz3r1Q X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2021 03:25:08 -0000 On Mon, Jan 11, 2021 at 6:10 PM Alan Somers wrote: > > The branch main has been updated by asomers: > > URL: https://cgit.FreeBSD.org/src/commit/?id=292808246db702b9194deb8938e40fd06914aea9 > > commit 292808246db702b9194deb8938e40fd06914aea9 > Author: Charlie Root Hmm, did your git client fill in the author name that way? Since... > AuthorDate: 2021-01-12 01:56:12 +0000 > Commit: Alan Somers > CommitDate: 2021-01-12 02:03:46 +0000 > > ICMP checksum test: Fix for big endian > > The in_cksum tests originally tried to simulate a BE environment by > swapping the byte order of the input. But that's overcomplicated, and > didn't actually work on real BE hardware. The correct testing strategy > is just to test on the native endianness, and run the tests in both BE > and LE environments. > > Submitted by: Renato Riolino ...given this submitted-by line, I am guessing it wasn't intended? > Reviewed By: asomers > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D23193 > ---