From owner-freebsd-usb@FreeBSD.ORG  Fri Jul 31 08:20:03 2009
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DA1BE1065672
	for <freebsd-usb@hub.freebsd.org>; Fri, 31 Jul 2009 08:20:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id C7FCD8FC17
	for <freebsd-usb@hub.freebsd.org>; Fri, 31 Jul 2009 08:20:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6V8K3WC085260
	for <freebsd-usb@freefall.freebsd.org>; Fri, 31 Jul 2009 08:20:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6V8K3nP085258;
	Fri, 31 Jul 2009 08:20:03 GMT (envelope-from gnats)
Date: Fri, 31 Jul 2009 08:20:03 GMT
Message-Id: <200907310820.n6V8K3nP085258@freefall.freebsd.org>
To: freebsd-usb@FreeBSD.org
From: Hans Petter Selasky <hselasky@c2i.net>
Cc: 
Subject: Re: usb/137189: [usb][patch] create and use sysctl nodes for HID
	report descriptors
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Hans Petter Selasky <hselasky@c2i.net>
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jul 2009 08:20:04 -0000

The following reply was made to PR usb/137189; it has been noted by GNATS.

From: Hans Petter Selasky <hselasky@c2i.net>
To: rea-fbsd@codelabs.ru
Cc: bug-followup@freebsd.org,
 freebsd-usb@freebsd.org
Subject: Re: usb/137189: [usb][patch] create and use sysctl nodes for HID report descriptors
Date: Fri, 31 Jul 2009 09:19:03 +0200

 On Thursday 30 July 2009 22:38:12 Eygene Ryabinkin wrote:
 > Hans Petter, good day.
 >
 > Tue, Jul 28, 2009 at 07:40:27PM +0400, Eygene Ryabinkin wrote:
 > > HPS wrote:
 > > > > Why do you dislike the sysctl approach? It is simple and reliable.
 > > >
 > > > It's duplicating access to data. There is not that much wrong about
 > > > it, except it will not work if the device is of another kind. I.E. you
 > > > would have to patch the HID sysctl node into every driver accessing
 > > > HID descriptors?
 > >
 > > Just now -- yes, I'll need it.  But probably I can move this
 > > functionality into the USB bus level -- it will automatically create
 > > this sysctl node for all HID children and will dispose it on the detach.
 > > usb_probe_and_attach() is a candidate for such functionality.  Will it
 > > be bad?
 >
 > OK, attached is the reworked version of the sysctl patch: it now creates
 > the needed nodes automatically (though they still can be created by
 > explicit call from the driver, as in uhid(4)).  As a bonus, kernel got the
 > ability to install per-USB class post-attach and pre-detach handlers, so
 > we can do some class-specific things for every driver.  What do you think
 > of it?
 
 Hi,
 
 I think it's too much code to doo too little, and adds extra complexity, and 
 that doing this via libusb would be much more generic.
 
 --HPS