From owner-cvs-src@FreeBSD.ORG Sun Feb 5 17:33:19 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 278BD16A420; Sun, 5 Feb 2006 17:33:19 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D6E1C43D45; Sun, 5 Feb 2006 17:33:18 +0000 (GMT) (envelope-from netchild@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k15HXIcb057340; Sun, 5 Feb 2006 17:33:18 GMT (envelope-from netchild@repoman.freebsd.org) Received: (from netchild@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k15HXIU8057339; Sun, 5 Feb 2006 17:33:18 GMT (envelope-from netchild) Message-Id: <200602051733.k15HXIU8057339@repoman.freebsd.org> From: Alexander Leidinger Date: Sun, 5 Feb 2006 17:33:18 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sound/pci csapcm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2006 17:33:19 -0000 netchild 2006-02-05 17:33:18 UTC FreeBSD src repository Modified files: sys/dev/sound/pci csapcm.c Log: A pointer was checked for NULL after dereferencing it. The check is not needed here, except there's a bug which results in detaching the device twice. Move the NULL pointer check to the beginning of the function and convert it into a KASSERT. CID: 420 Found with: Coverity Prevent(tm) Discussed with: ariff MFC after: 5 days Revision Changes Path 1.36 +4 -4 src/sys/dev/sound/pci/csapcm.c