From owner-freebsd-commit Thu Oct 26 05:44:59 1995 Return-Path: owner-commit Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA04642 for freebsd-commit-outgoing; Thu, 26 Oct 1995 05:44:59 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA04630 for cvs-all-outgoing; Thu, 26 Oct 1995 05:44:56 -0700 Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id FAA04620 for cvs-sys-outgoing; Thu, 26 Oct 1995 05:44:53 -0700 Received: from Sysiphos (Sysiphos.MI.Uni-Koeln.DE [134.95.212.10]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id FAA04615 ; Thu, 26 Oct 1995 05:44:39 -0700 Received: by Sysiphos id AA24313 (5.67b/IDA-1.5); Thu, 26 Oct 1995 13:42:45 +0100 Message-Id: <199510261242.AA24313@Sysiphos> From: se@zpr.uni-koeln.de (Stefan Esser) Date: Thu, 26 Oct 1995 13:42:45 +0100 In-Reply-To: David Greenman "cvs commit: src/sys/pci if_de.c" (Oct 26, 0:40) X-Mailer: Mail User's Shell (7.2.6 alpha(2) 7/9/95) To: David Greenman Subject: Re: cvs commit: src/sys/pci if_de.c Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, matt@lkg.dec.com Sender: owner-commit@FreeBSD.org Precedence: bulk On Oct 26, 0:40, David Greenman wrote: } Subject: cvs commit: src/sys/pci if_de.c } davidg 95/10/26 00:40:16 } } Modified: sys/pci if_de.c } Log: } From Matt Thomas: } } "I screwed the initialization of the burstsize. Right now it will default } to 0 (which can cause corruption problems on high latency PCI buses). It } should be set to 8 longwords to avoid problems with certain PCI chipsets." } } Submitted by: Matt Thomas There is a global variable for the purpose of determining the maximum burst length. It is currently initialized to 4 longwords, but I guess having it default to 8 would be Ok. (We reduced it to 4 because of a problem reported by Matt Thomas with an old Saturn chip set revision). This variable is supposed to be used by all drivers that support burst transfers. It can be adjusted from the PCI host bridge probe code, if necessary or advantegous. Quoting from /sys/pci/pci.c: /*======================================================== ** ** Variables ** **======================================================== */ /* ** log2 of safe burst len (in words) */ unsigned pci_max_burst_len = 2; /* 2=16Byte, 3=32Byte, 4=64Byte, ... */ I'd really prefer if this mechanism was used ... (I intend to clean up the PCI and NCR code later this year. This will lead to significant simplifications, and I'd like to share as much code as possible with the new EISA and possibly PCMCIA code ...) Regards, STefan -- Stefan Esser, Zentrum fuer Paralleles Rechnen Tel: +49 221 4706021 Universitaet zu Koeln, Weyertal 80, 50931 Koeln FAX: +49 221 4705160 ============================================================================== http://www.zpr.uni-koeln.de/~se