From owner-svn-src-all@FreeBSD.ORG  Thu Jan  2 07:16:36 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D722E8AA;
 Thu,  2 Jan 2014 07:16:36 +0000 (UTC)
Received: from mx0.deglitch.com (unknown [IPv6:2001:16d8:ff00:19d::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 853671D4F;
 Thu,  2 Jan 2014 07:16:36 +0000 (UTC)
Received: from [192.168.1.12] (unknown [37.113.188.17])
 by mx0.deglitch.com (Postfix) with ESMTPSA id 5CADE8FC40;
 Thu,  2 Jan 2014 11:16:26 +0400 (MSK)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\))
Subject: Re: svn commit: r255219 - in head: contrib/tcpdump lib/libc
 lib/libc/capability lib/libc/include lib/libc/sys lib/libprocstat
 sbin/dhclient sbin/hastd sys/amd64/linux32 sys/bsm
 sys/cddl/compat/opensola...
From: Stanislav Sedov <stas@freebsd.org>
In-Reply-To: <201309050009.r8509vsE061271@svn.freebsd.org>
Date: Wed, 1 Jan 2014 23:16:22 -0800
Content-Transfer-Encoding: quoted-printable
Message-Id: <67DFFD7B-01DE-4862-BED3-DD42EB92A8F4@freebsd.org>
References: <201309050009.r8509vsE061271@svn.freebsd.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
X-Mailer: Apple Mail (2.1827)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jan 2014 07:16:36 -0000


On Sep 4, 2013, at 5:09 PM, Pawel Jakub Dawidek <pjd@FreeBSD.org> wrote:

>  This commit also breaks compatibility with some existing Capsicum =
system calls,
>  but I see no other way to do that. This should be fine as Capsicum is =
still
>  experimental and this change is not going to 9.x.

Hi!

This change also increases the size of kinfo_file structure, which won=92t=
 allow
programs not compiled against HEAD and working with kern.info.filedesc =
sysctl
to run properly on HEAD (e.g. 8.x, 9.x and 10.x jails won=92t run =
properly on HEAD,
and it also broke valgrind).  Is there absolutely no way to avoid =
extending the size
of this struct?

Thanks!

>  #if defined(__amd64__) || defined(__i386__)
> -#define        KINFO_FILE_SIZE 1392
> +#define        KINFO_FILE_SIZE 1424
>  #endif
> =20
>  struct kinfo_file {
> @@ -389,6 +390,7 @@
>         uint16_t        kf_pad1;                /* Round to 32 bit =
alignment. */
>         int             _kf_ispare0;            /* Space for more =
stuff. */
>         cap_rights_t    kf_cap_rights;          /* Capability rights. =
*/
> +       uint64_t        _kf_cap_spare[3];       /* Space for future =
cap_rights_t. */
>         int             _kf_ispare[4];          /* Space for more =
stuff. */
>         /* Truncated before copyout in sysctl */
>         char            kf_path[PATH_MAX];      /* Path to file, if =
any. */

--
ST4096-RIPE