From nobody Fri Jul 31 18:01:06 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBYm45kPSz6nG0c for ; Fri, 31 Jul 2026 18:01:24 +0000 (UTC) (envelope-from dmarck@gmail.com) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBYm40LBjz49Rj for ; Fri, 31 Jul 2026 18:01:24 +0000 (UTC) (envelope-from dmarck@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5b28c91fba5so1352901e87.1 for ; Fri, 31 Jul 2026 11:01:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785520882; x=1786125682; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kaY1OqPnuGT1FFV98L7GW/eT1l1MiXV9xYIiWZgpEkg=; b=YWGWTAN3gZI+EsOAP/8p41eV/ItnCzJhdejQhZRwRIQZ2V75snJP3gslSLWr4zRbqm PDDAIuIaqh8V3C1p4t+e2t7F4HxcMQ0H/UQwVXhdu9e9/zgazj91BfKSDHYsQktRNGnp vF4n06KGmGBYCQdyj90vUSFfsC42BUqtTGBQNIYwadjF4zhI5TCCyAWpkJPrOhumjfz4 wvJaLMvn1YkU7Zjmf26kbjh7JVk/bP7fjII64osvc7x75ORvR7Fui6nzmq0YGxgqQbtF Zc1d1oF0QpRSPuavb4TkA1Of2A636/dAvqdoYTdriQ/cr9nQ2l89iXdNR/KVXF5A/KoB jxyg== X-Forwarded-Encrypted: i=1; AHgh+RothTXSM4sdm3OWcn2OagVwUUJuBi1Nog9wp7C/z9hdhNjRupRP5d8gcsO+ecU2yYuK+qqIIACSh/xjHxcQx99+GHks@freebsd.org X-Gm-Message-State: AOJu0YzmigMeG30VQP+q2Cvc9kXTDoUVB33+cZm0bucjCslFD/uCxGX9 sveAGs4efwuAA2Gl1TEFASgzexR89AL7/GVfhe8j8RGL6nbuZ3dCWqc0 X-Gm-Gg: AR+sD12Hfkx47Nc7E0/wQ0sekE4yJ4FUXOfv70B4vsh2q5nzt2oGqCjz2SZkMvF5P01 QAhPv+owxoOyFy+7fdTtw0p7UNI1fUIwVO9mo9oJuIKrv2lbzd13gxXh77gAzojVvp4BWjp/m+b rUxQ5UXKZRvR2QY6hLgiBb3239N1pbV6qA7yFUa6fnvIfppwGI9Wf3c6PwXLFgHP4ymRnpOTjAJ kjnevk1NRDHsIc1URkFAGZrsKra87tzQ9caSN+Wx7+9H2fIjuIeI01UBrzxsCPC+3YpW1EX4/MN xapMeY+QiW+MkRYOWmGZN1ljlQ9Va6B+SI73SECV4WvOJPWmkAH/2841XhSZumFOJAeDOjYSWpD T3rZP7mXqHLRcLaS3dFkNP1QJDeCw1T4JliPV8vkleVlNjZDOtZz52DiSLbAKmxg4rAWuReQnrw gVkDvgFVBfwSGcgToFjvSK9xv2te0qaQZABZiiHfmY3ZjaT4xkErChZi/pXNpRDe/QS3g8GiLCC CcBurrpm1WjQA== X-Received: by 2002:a05:6512:3e1e:b0:5b2:95d3:142e with SMTP id 2adb3069b0e04-5b2e4f5a855mr96453e87.24.1785520881510; Fri, 31 Jul 2026 11:01:21 -0700 (PDT) Received: from [10.0.85.2] ([166.1.129.26]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2e23cbf5asm482132e87.32.2026.07.31.11.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 11:01:20 -0700 (PDT) Message-ID: <8d8b4b46-b5b8-41cb-be17-fc51128c8a94@woozle.net> Date: Fri, 31 Jul 2026 21:01:06 +0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 8aec309852b5 - main - stand: Remove a pointless goto To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6a6ce20e.3f382.1f114d7@gitrepo.freebsd.org> Content-Language: en-US From: Dmitry Morozovsky In-Reply-To: <6a6ce20e.3f382.1f114d7@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4hBYm40LBjz49Rj X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- Hohn, On 31.07.2026 20:57, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=8aec309852b5285cfa03424f7776a0bf432dff7a > > commit 8aec309852b5285cfa03424f7776a0bf432dff7a > Author: John Baldwin > AuthorDate: 2026-07-31 17:50:33 +0000 > Commit: John Baldwin > CommitDate: 2026-07-31 17:50:33 +0000 > > stand: Remove a pointless goto > > Commit 505222d35fea removed a batch of code that this goto used to skip > around. > > Reviewed by: olce, kib, markj > Fixes: 505222d35fea ("Implement the long-awaited module->file cache database. A userland tool (kldxref(8)) keeps a cache of what modules and versions are inside what .ko files. I have tested this on both Alpha and i386.") > Differential Revision: https://reviews.freebsd.org/D58539 > --- > stand/common/load_elf.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/stand/common/load_elf.c b/stand/common/load_elf.c > index 1c4efb8c4156..97467094750c 100644 > --- a/stand/common/load_elf.c > +++ b/stand/common/load_elf.c > @@ -921,9 +921,6 @@ nosyms: > if (__elfN(parse_modmetadata)(fp, ef, p_start, p_end) == 0) > goto out; > > - if (ef->kernel) /* kernel must not depend on anything */ > - goto out; > - but then previous check becomes useless too, isn't it? > out: > if (dp) > free(dp); > -- Sincerely, D.Marck [MCK-RIPE] [ FreeBSD committer: marck@FreeBSD.org ] --------------------------------------------------------------------------- *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- woozle@woozle.net *** ---------------------------------------------------------------------------